From owner-svn-src-all@freebsd.org Tue Sep 6 21:58:23 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3B6C4BCDC31; Tue, 6 Sep 2016 21:58:23 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C3350F27; Tue, 6 Sep 2016 21:58:22 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm0-x231.google.com with SMTP id b187so86510354wme.1; Tue, 06 Sep 2016 14:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=45zJqK3MAZnEE/+UQxrFMqmt6LQM/D+uh0aMJWLWUi8=; b=qnuf+l7qkHvXLTc9H6mk27hh4h6EecKhrRpm8sPC6diYLI8jIXnD+b3OYzwigaPcI1 hxV2+0eH0RMaIKEEbV4MlUv0QMv/UZrdI6H4EVsf6RGIimuLdINpwdZ2FutFBjLw3iF5 McVK2JFkIBOgz7/bmNDLnWdwJQPL5uFVoOGYSoziNJzjXHdDfR2XHcrjV6m1FbmtIuuS +RMkUsKxZqONmTRfOHYFyuH9n506NJRptfa7khwCcEC6bRx5b8W/RTQe0gTvXGgg8gvL pNiHfnDC7/q2D6XslyRjVrRZMVmesWLdAqfm7GKTTzOnQWm888Y7Nieuxg/M94/8RK+3 Rn/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=45zJqK3MAZnEE/+UQxrFMqmt6LQM/D+uh0aMJWLWUi8=; b=lLEhIRxXqps6x2EuFnUIO1b1XMx9IF8BBJlnGBQQttDov/kIHIz+l3h8YeDPsvWlVU 9iUR7qTgU7ZRnDC2xir1xs16eYbCxHJYmGrCbVn258f6h7UpaFc7p7rizgxBcEhtvp+k GLMQldEOI+4fhKinwqbS481Gjr5dr2MnVhLjGKQ8iwx16l3xgFhjw5qSoI0CH8NeLXr6 ow0CaPml6JMVjC3p49Rtpmdhfqf9ZOpSZ90lGq/W0OvmA07yi0DKuBI6WsVSGUTK2IPd fIdJQjroy9QWTsPTQkGXSaXrW7f+e30JCRpSpmnJ8uPD8K9lhHSdKx7WzNP+P68kDAIg tgtw== X-Gm-Message-State: AE9vXwMT+gc6rkLdQ7NPt0pGbYg5DH36krKPgSMqsi96HpvlKik/KXV7VJ+QfS/VRC9E5A== X-Received: by 10.194.65.100 with SMTP id w4mr18190567wjs.149.1473199101170; Tue, 06 Sep 2016 14:58:21 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id g7sm35421979wjx.10.2016.09.06.14.58.20 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 06 Sep 2016 14:58:20 -0700 (PDT) Date: Tue, 6 Sep 2016 23:58:18 +0200 From: Mateusz Guzik To: Andriy Gapon Cc: Mateusz Guzik , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org, Konstantin Belousov Subject: Re: svn commit: r305504 - head/sys/fs/nullfs Message-ID: <20160906215818.GD23680@dft-labs.eu> References: <201609062122.u86LM3hf032522@repo.freebsd.org> <20160906215149.GC23680@dft-labs.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160906215149.GC23680@dft-labs.eu> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Sep 2016 21:58:23 -0000 On Tue, Sep 06, 2016 at 11:51:49PM +0200, Mateusz Guzik wrote: > On Wed, Sep 07, 2016 at 12:46:44AM +0300, Andriy Gapon wrote: > > On 07/09/2016 00:22, Mateusz Guzik wrote: > > > nullfs: stop special-casing directories in null_vptocnp > > > > > > The previous code was forcing an expensive walk in vop_stdvptocnp, > > > which was causing performance issues on highly contended zfs. > > > > In other words, the name cache was always bypassed for directories? > > > > Or whatever the target fs had in store for resolving names. > > This particular thing was causing a lot of idle time on my poudriere > tests due to lockmgr contention. > To be clear, this is not name -> vp translation, but the other way around (e.g. for getcwd). -- Mateusz Guzik