From owner-cvs-all@FreeBSD.ORG Wed Jun 7 08:22:31 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4CC2616BDF6 for ; Wed, 7 Jun 2006 08:03:50 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.FreeBSD.org (Postfix) with SMTP id C45D643D55 for ; Wed, 7 Jun 2006 08:03:48 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 18039 invoked by uid 399); 7 Jun 2006 08:03:47 -0000 Received: from localhost (HELO ?192.168.0.3?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 7 Jun 2006 08:03:47 -0000 Message-ID: <44868860.1020706@FreeBSD.org> Date: Wed, 07 Jun 2006 01:03:44 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 1.5.0.4 (X11/20060604) MIME-Version: 1.0 To: Munechika SUMIKAWA References: <200606070733.k577XaTm091050@repoman.freebsd.org> In-Reply-To: <200606070733.k577XaTm091050@repoman.freebsd.org> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, Vivek Khera , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/security/racoon2 Makefile pkg-plist ports/security/racoon2/files patch-samples-Makefile.in patch-samples-rc.d-iked.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2006 08:22:36 -0000 Munechika SUMIKAWA wrote: > sumikawa 2006-06-07 07:33:36 UTC > > FreeBSD ports repository > > Modified files: > security/racoon2 Makefile pkg-plist > security/racoon2/files patch-samples-Makefile.in > Added files: > security/racoon2/files patch-samples-rc.d-iked.in > Log: > clean up startup scripts. One problem, one suggestion. :) First, what you really want to do is change rcvar: rcvar=`set_rcvar` Which will work on both FreeBSD and NetBSD. In FreeBSD you would be better off deleting the required_vars line (which I don't think is useful in NetBSD either, but I wouldn't swear to it). If I were you, I'd suggest both of these changes upstream. The suggestion would be to do these kinds of very small and obvious changes using sed in the Makefile, as opposed to using patches, since the former causes less repo bloat, but that's a style issue. hth, Doug > PR: ports/91312 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=91312 > Reported by: Vivek Khera > > Revision Changes Path > 1.44 +1 -1 ports/security/racoon2/Makefile > 1.4 +2 -3 ports/security/racoon2/files/patch-samples-Makefile.in > 1.1 +11 -0 ports/security/racoon2/files/patch-samples-rc.d-iked.in (new) > 1.10 +0 -1 ports/security/racoon2/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/racoon2/Makefile.diff?&r1=1.43&r2=1.44&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/racoon2/files/patch-samples-Makefile.in.diff?&r1=1.3&r2=1.4&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/racoon2/files/patch-samples-rc.d-iked.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/racoon2/pkg-plist.diff?&r1=1.9&r2=1.10&f=h > -- This .signature sanitized for your protection