From owner-svn-src-head@FreeBSD.ORG Sat Feb 14 23:17:28 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3B5DC1065673; Sat, 14 Feb 2009 23:17:28 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 0F6038FC0C; Sat, 14 Feb 2009 23:17:27 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n1ENHR03059433 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 14 Feb 2009 15:17:27 -0800 (PST) (envelope-from sam@freebsd.org) Message-ID: <49975107.1070803@freebsd.org> Date: Sat, 14 Feb 2009 15:17:27 -0800 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.18 (X11/20081209) MIME-Version: 1.0 To: Alexander Motin References: <200902142302.n1EN2xp0032837@svn.freebsd.org> In-Reply-To: <200902142302.n1EN2xp0032837@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DCC--Metrics: ebb.errno.com; whitelist Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r188621 - head/sys/dev/ata/chipsets X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Feb 2009 23:17:28 -0000 Alexander Motin wrote: > Author: mav > Date: Sat Feb 14 23:02:59 2009 > New Revision: 188621 > URL: http://svn.freebsd.org/changeset/base/188621 > > Log: > Tunes to AHCI reset sequences: > - specification claims that 1 second is just a maximum controller reset time; > implement controller reset properly to save almost 1 second of boot, and > about half second of resume time; > - enable channel interrupts only after channel status reset to fix duplicate > device creation on resume due to unwanted device connection event; > - as described in specification, wait for disk ready status after channel > power-up; it is not so important when disk already touched by BIOS, but > solves device not ready problems on resume and probably some other cases. > - uncomment channel stop/start on soft-reset as it is declared mandatory by > specification; it was commented due to some random drive detection problems > on VIA and JMicron controllers, but I hope it is fixed by previous point. > > These sounds like unrelated changes. Given the fragility of ata interop you should do these as separate commits in case folks need to bisect changes on breakage. Sam