From owner-freebsd-current Mon Sep 18 5:48: 9 2000 Delivered-To: freebsd-current@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 0692837B42C; Mon, 18 Sep 2000 05:48:05 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id XAA19037; Mon, 18 Sep 2000 23:47:52 +1100 Date: Mon, 18 Sep 2000 23:47:49 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Warner Losh Cc: sanpei@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: Please review: small change in sys/i386/isa/clock.c and sys/alpha/alpha/clock.c for PC-Card melody beep code. In-Reply-To: <200009171838.MAA24081@harmony.village.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 17 Sep 2000, Warner Losh wrote: > I've seen these patches many times and think that it is a good idea. > This interface needs to be exported so that the pccard system sounds > don't interfere with normal systme sounds. It needs locking changes to be exportable: 1) splhigh()/splx(), at least in RELENG_4 where there is no giant lock and spl*() has a non-null effect, so that callers don't need to know that it must be called at splsoftclock() or higher. 2) Honor the current locking protocol acquire_timer2()/release_timer2() -- don't do anything if (!beeping). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message