From owner-freebsd-net@FreeBSD.ORG Thu Nov 25 14:06:48 2004 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 16CFA16A4CE for ; Thu, 25 Nov 2004 14:06:48 +0000 (GMT) Received: from relay.bestcom.ru (relay.bestcom.ru [217.72.144.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3D43C43D4C for ; Thu, 25 Nov 2004 14:06:47 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (root@cell.sick.ru [217.72.144.68]) by relay.bestcom.ru (8.13.1/8.12.9) with ESMTP id iAPE6gaj078553 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Thu, 25 Nov 2004 17:06:43 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id iAPE6f4Q078342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 25 Nov 2004 17:06:42 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id iAPE6fFi078341 for net@freebsd.org; Thu, 25 Nov 2004 17:06:41 +0300 (MSK) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Thu, 25 Nov 2004 17:06:41 +0300 From: Gleb Smirnoff To: net@freebsd.org Message-ID: <20041125140641.GA78210@cell.sick.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Kj7319i9nmIyA2yE" Content-Disposition: inline User-Agent: Mutt/1.5.6i X-Virus-Scanned: clamd / ClamAV version devel-20041013, clamav-milter version 0.75l on 127.0.0.1 X-Virus-Status: Clean Subject: route cacheing for gif(4) should be optional X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Nov 2004 14:06:48 -0000 --Kj7319i9nmIyA2yE Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Back to this problem: http://freebsd.rambler.ru/bsdmail/freebsd-net_2004/msg01305.html I've found two more people who dislike this feature of gif(4). So I'd like to make it optional. We already have LINK2 flag removing sourceroute filter from gif(4), which is commonly used in asymmetrically routed networks. I suggest to use this flag also for disabling route cacheing, since asymmetricity often appears in dynamically routed networks, and if one runs dynamic routing, he probably wants to remove route cacheing, too. Any objections? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE --Kj7319i9nmIyA2yE Content-Type: text/plain; charset=koi8-r Content-Disposition: attachment; filename="in_gif.c.diff" Index: in_gif.c =================================================================== RCS file: /home/ncvs/src/sys/netinet/in_gif.c,v retrieving revision 1.26 diff -u -r1.26 in_gif.c --- in_gif.c 18 Jun 2004 02:04:07 -0000 1.26 +++ in_gif.c 25 Nov 2004 17:16:14 -0000 @@ -209,6 +209,12 @@ } error = ip_output(m, NULL, &sc->gif_ro, 0, NULL, NULL); + + if ((sc->gif_if.if_flags & IFF_LINK2) != 0) { + RTFREE(sc->gif_ro.ro_rt); + sc->gif_ro.ro_rt = NULL; + } + return (error); } --Kj7319i9nmIyA2yE--