Date: Fri, 8 Jan 2016 13:32:02 -0800 From: Gleb Smirnoff <glebius@FreeBSD.org> To: NGie Cooper <yaneurabeya@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r293439 - in head: lib/libc/sys sys/dev/ti sys/kern sys/sys usr.bin/netstat Message-ID: <20160108213202.GI1906@FreeBSD.org> In-Reply-To: <88B48C42-DFEF-4CAE-973E-BDF2A408B4A3@gmail.com> References: <201601082034.u08KYvLv075281@repo.freebsd.org> <96B980EE-FD2F-490E-BA5E-4F23A67CEB18@gmail.com> <20160108211041.GG1906@FreeBSD.org> <88B48C42-DFEF-4CAE-973E-BDF2A408B4A3@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 08, 2016 at 01:22:45PM -0800, NGie Cooper wrote: N> > 1) The review requests were sent continuosly to arch@ during last 1.5 years. N> > N> > https://lists.freebsd.org/pipermail/freebsd-arch/2014-May/015385.html N> > N> > 2) Team of engineers at Netflix has a lot of code build on top of that code, N> > e.g. SSL_sendfile(). Of course, writing something on top assumes reviewing, N> > so assume it reviewed thoroughly by rrs@. Actually, here is list of people N> > who did some review of the code: emax@, rrs@, scottl@, gallatin@, imp@. N> > N> > 3) Do you have any particulars concerns with this change or those made recently N> > to sys/kern and sys/net*? N> N> I don’t as of right now, other than it’s really difficult to audit changes and assess risk if someone doesn’t have access to the CRs :(. N> N> Also… N> N> N> > An N> N> > explanation of why such behavior is beneficial compared to old one is N> N> > going to be too long for a commit message, so we will skip it here. N> N> This wasn’t really helpful. It would have been nice if there was a wiki page or some other reference used in this commit which would have described the where, why, and how behind this change a lot more. I'm writing status report on this right now. Also there is slideshare: http://www.slideshare.net/facepalmtarbz2/new-sendfile-in-english And there is even a paper, alas in Russian. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160108213202.GI1906>