From owner-freebsd-current  Tue Jun 18 16:17:23 1996
Return-Path: owner-current
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id QAA08169
          for current-outgoing; Tue, 18 Jun 1996 16:17:23 -0700 (PDT)
Received: from rocky.sri.MT.net (rocky.sri.MT.net [204.182.243.10])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id QAA08152
          for <current@FreeBSD.org>; Tue, 18 Jun 1996 16:17:18 -0700 (PDT)
Received: (from nate@localhost) by rocky.sri.MT.net (8.6.12/8.6.12) id RAA03785; Tue, 18 Jun 1996 17:17:16 -0600
Date: Tue, 18 Jun 1996 17:17:16 -0600
From: Nate Williams <nate@sri.MT.net>
Message-Id: <199606182317.RAA03785@rocky.sri.MT.net>
To: current@FreeBSD.org
Subject: (Mis)feature of the current make macros
Sender: owner-current@FreeBSD.org
X-Loop: FreeBSD.org
Precedence: bulk

I noticed this with the PC-CARD stuff, but if you have a man-page
definition, ../Makefile.inc gets included twice.  Normally this isn't a
problem, but in the case where you set something with '+=' you'll end up
with it added to the variable twice.

Ex:


% cat Makefile
SUBDIR = subdir

.include <bsd.subdir.mk>
% cat Makefile.inc
CFLAGS += -Wall
% cd subdir
% cat Makefile
PROG=   bar
SRCS=   bar.c
MAN8=   bar.8

.include <bsd.prog.mk>
% touch bar.c bar.8
% make -n
cc -Wall   -Wall bar.c
cc -Wall   -Wall  -o bar bar.o
zip -c bar.8 > bar.8.gz

[ If you comment the MAN8 entry it behaves as expected ]

Is there any Makefile that only includes <bsd.man.mk>?  If so, should
it?  If not, we can remove the inclusion of ../Makefile.inc.

Does anyone know if I'm missing anything here?  (Other than my sanity?
*grin*)



Nate