From owner-freebsd-current@FreeBSD.ORG Mon Jul 11 21:48:06 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D90261065672 for ; Mon, 11 Jul 2011 21:48:06 +0000 (UTC) (envelope-from lacombar@gmail.com) Received: from mail-pv0-f182.google.com (mail-pv0-f182.google.com [74.125.83.182]) by mx1.freebsd.org (Postfix) with ESMTP id A2D028FC1B for ; Mon, 11 Jul 2011 21:48:06 +0000 (UTC) Received: by pvg11 with SMTP id 11so4214617pvg.13 for ; Mon, 11 Jul 2011 14:48:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=/qfTeVfYRhf2ROQpIXJvTlIo6OxQQijjlXZ89Pot8rw=; b=YIYa6Kw2yre7b3kP+UAPgeO2MCEtrlgUfPUbCKuCjfoo0aTPzBPaJqj46xxowi59PL FG30nXa16FzKJl6hlWxgMOIJ1YkyWSBRvjizvM2GEURgiocT05Nu51cnfjfHGPHhffav AyvZUdKsY99QZ4dECs6Zm/DPsPl6DRzIltqrw= MIME-Version: 1.0 Received: by 10.68.41.34 with SMTP id c2mr7922727pbl.340.1310420886153; Mon, 11 Jul 2011 14:48:06 -0700 (PDT) Received: by 10.68.49.42 with HTTP; Mon, 11 Jul 2011 14:48:06 -0700 (PDT) In-Reply-To: <4E1B67C7.8040402@FreeBSD.org> References: <4E1421D9.7080808@zedat.fu-berlin.de> <4E147F54.40908@zedat.fu-berlin.de> <20110706162811.GA68436@troutmask.apl.washington.edu> <20110706193636.GA69550@troutmask.apl.washington.edu> <4E14CCE5.4050906@zedat.fu-berlin.de> <20110707015151.GB71966@troutmask.apl.washington.edu> <4E1B67C7.8040402@FreeBSD.org> Date: Mon, 11 Jul 2011 17:48:06 -0400 Message-ID: From: Arnaud Lacombe To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Current Subject: Re: Heavy I/O blocks FreeBSD box for several seconds X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2011 21:48:06 -0000 Hi, On Mon, Jul 11, 2011 at 5:14 PM, Andriy Gapon wrote: > on 11/07/2011 23:33 Arnaud Lacombe said the following: >> For the record, I would like to see enforced public review for _every_ >> patch *before* it is checked in, as a strong rule. gcc system is >> particularly interesting. But it is not likely to happen in FreeBSD >> where FreeBSD committers are clearly more free than other at >> checking-in un-publicly-reviewed stuff (especially _bad_ stuff). >> >> This would of course apply even to long-time committers, no matter how >> it hurt their ego (which I definitively do not care about). > > Have you just volunteered to review all of the patches that I would like = to > commit? =A0And are you prepared to take responsibility for quality of you= r reviews? > I am sure that other developers will gladly accept your offer too. > _No-one_ can do all the reviews, especially not me (on a purely technical level). ACK must come from subsystem maintainers. Having public review would allow the community review, which is now just not possible today. As about patches from the maintainer, they might be committed without his approval, but still sent for review. If a maintainer goes outside his area, he has to get approval from the other subsystem maintainer. - Arnaud