From owner-p4-projects@FreeBSD.ORG Mon Jun 21 01:26:00 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 22BC11065676; Mon, 21 Jun 2010 01:26:00 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DACB41065672; Mon, 21 Jun 2010 01:25:59 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 6F50D8FC14; Mon, 21 Jun 2010 01:25:59 +0000 (UTC) Received: by iwn7 with SMTP id 7so3677524iwn.13 for ; Sun, 20 Jun 2010 18:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=mJS8+GmG/+Ft+hfIVi71qzuPsrwX/cprgLS9Dcx657s=; b=ZLRwbbswr8m6a3h5ox/aXVPiluG9GNEq7gH+szUtp9XJtON6vegnySQ6F7CTaGBudn /f4LK/H6XoXDEJmeCfu5SWKGfq92QvlcnQInX+oVfW0rkVJxKSDOlNb2JNW5kq8vv8M6 VY4gsAxaeyzmKIE8HsRw9kZ8fItT2q3q500Y0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=XNVMqG3od3h2fI1iuCTqXUGJhbssq5etmPyAHYfB+AkI5XRzaM15+v/btar0kqZOL0 fKohmEmRP/M/mEMcFMHh4t9oGRDfgy2eF5xwVAptoHhEtBMVUb9M13W5drxO86+tHzKg AnIPVLa/0QHKLvvuoWa40Xc2XV2TbRDQhjJX8= MIME-Version: 1.0 Received: by 10.231.45.144 with SMTP id e16mr5093261ibf.130.1277083558836; Sun, 20 Jun 2010 18:25:58 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.231.117.201 with HTTP; Sun, 20 Jun 2010 18:25:58 -0700 (PDT) In-Reply-To: References: <201006210045.o5L0jgZ3009138@repoman.freebsd.org> Date: Sun, 20 Jun 2010 18:25:58 -0700 X-Google-Sender-Auth: NWDcvIXtOZt5lgsya3JBMKnJB1I Message-ID: From: Garrett Cooper To: Ivan Voras Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Andrew Pantyukhin , Perforce Change Reviews , Julien LAFFAYE Subject: Re: PERFORCE change 180026 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2010 01:26:00 -0000 On Sun, Jun 20, 2010 at 6:15 PM, Ivan Voras wrote: > On 21 June 2010 02:58, Julien LAFFAYE wrote: >> Hi, >> >> On Sun, Jun 20, 2010 at 5:45 PM, Ivan Voras wrote: >>> >>> http://p4web.freebsd.org/@@180026?ac=3D10 >>> >>> Change 180026 by ivoras@betelgeuse on 2010/06/21 00:45:03 >>> >>> =A0 =A0 =A0 =A0Finished most of +CONTENTS reading code, still a few thi= ngs to go >>> =A0 =A0 =A0 =A0and certainly edge-cases resulting from the uglyness and= adhockery >>> =A0 =A0 =A0 =A0of the format. >>> >> >> Why don't you use read_plist(Package *pkg, int fd) from libpkg instead? > > Should I, in the light of > YES_I_KNOW_THE_API_IS_RUBBISH_AND_IS_DOOMED_TO_CHANGE ? I thought the > entire lib is to be rightfully scrapped and implemented as something > decent. Yes, it will be eventually, but there's no real harm in implementing this bit with read_plist for the time being though. If and when dforsyth's work gets straightened out, a lot of this crud will get scrapped and/or properly rewritten. Thanks, -Garrett