From owner-svn-src-all@FreeBSD.ORG Fri Jul 23 02:39:50 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CC6AC1065678; Fri, 23 Jul 2010 02:39:50 +0000 (UTC) (envelope-from prvs=181377e559=brian@Awfulhak.org) Received: from idcmail-mo1so.shaw.ca (idcmail-mo1so.shaw.ca [24.71.223.10]) by mx1.freebsd.org (Postfix) with ESMTP id 5F5808FC14; Fri, 23 Jul 2010 02:39:50 +0000 (UTC) Received: from pd3ml2so-ssvc.prod.shaw.ca ([10.0.141.138]) by pd4mo1so-svcs.prod.shaw.ca with ESMTP; 22 Jul 2010 20:24:49 -0600 X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.0 c=1 a=qID9P7akmeUA:10 a=VphdPIyG4kEA:10 a=kj9zAlcOel0A:10 a=MJPcHhXccCG8eBs0us8XwA==:17 a=PO7r1zJSAAAA:8 a=MMwg4So0AAAA:8 a=6I5d2MoRAAAA:8 a=dvJ3t3TJ3SQnWsjhJfkA:9 a=CceUWs8JkLarRc7w9XkA:7 a=nRnIvffNZJi5ykp4BLC8PpG4ErYA:4 a=CjuIK1q_8ugA:10 a=WJ3hkfHDukgA:10 a=SV7veod9ZcQA:10 a=RHrfkHpQvswXW2zu:21 a=JsF-MKW5R31p3vNC:21 Received: from unknown (HELO store.lan.Awfulhak.org) ([70.79.162.198]) by pd3ml2so-dmz.prod.shaw.ca with ESMTP; 22 Jul 2010 20:24:49 -0600 Received: from store.lan.Awfulhak.org (localhost.localdomain [127.0.0.1]) by localhost (Email Security Appliance) with SMTP id 1580FC433AA_C48FD71B; Fri, 23 Jul 2010 02:24:49 +0000 (GMT) Received: from gw.Awfulhak.org (gw.lan.Awfulhak.org [172.16.0.1]) by store.lan.Awfulhak.org (Sophos Email Appliance) with ESMTP id A7654C460F4_C48FD6BF; Fri, 23 Jul 2010 02:24:43 +0000 (GMT) Received: from dev.lan.Awfulhak.org (brian@dev.lan.Awfulhak.org [172.16.0.5]) by gw.Awfulhak.org (8.14.4/8.14.4) with ESMTP id o6N2OhUL007678; Thu, 22 Jul 2010 19:24:43 -0700 (PDT) (envelope-from brian@Awfulhak.org) Date: Thu, 22 Jul 2010 19:24:42 -0700 From: Brian Somers To: Bruce Evans Message-ID: <20100722192442.753c0e09@dev.lan.Awfulhak.org> In-Reply-To: <20100721194659.L7533@delplex.bde.org> References: <201007210843.o6L8hmo5064622@svn.freebsd.org> <20100721090623.GA21607@FreeBSD.org> <20100721194659.L7533@delplex.bde.org> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i386-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, Alexey Dokuchaev , src-committers@FreeBSD.org, Kai Wang , svn-src-all@FreeBSD.org Subject: Re: svn commit: r210321 - head/lib/libelf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2010 02:39:50 -0000 On Wed, 21 Jul 2010 19:51:49 +1000 (EST) Bruce Evans wrote: > On Wed, 21 Jul 2010, Alexey Dokuchaev wrote: > > > On Wed, Jul 21, 2010 at 08:43:48AM +0000, Kai Wang wrote: > >> Log: > >> Remove a superfluous comment. > >> > >> Obtained from: elftoolchain > >> MFC after: 1 month > > > > (Just picking random of the similar commits): guys, please, try to > > uniformly align commit meta tags: > > It is perfectly aligned with tabs (and no 2-char commit mail indentation, > and no N-char mailer quoting). > > > Obtained from: somewhere > > MFC after: sometime > > Foo bar: baz qux ... > > > > Broken alignment considerably pessimizes commit log grasping, as it > > requires more post-processing work after reading it off. > > Do you mean for human grasping and automated post-processing? The automation > should have no problems with the whitespace but might with the mailer quoting. > > "tags" should mean the part before the ":". Aligning those by making them > all of the same length would help. Alternatively, indenting commit mail sections with a tab rather than two spaces would preserve the visual alignment. -- Brian Somers Don't _EVER_ lose your sense of humour !