From nobody Sun Mar 22 06:02:34 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fdm1D2S1Yz6W2Lw for ; Sun, 22 Mar 2026 06:02:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fdm1D08njz3Q5j for ; Sun, 22 Mar 2026 06:02:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774159360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CmbMpddH4hjkGc2mZy+cR4MAQgf954dTzIn52B3FWw8=; b=yZiGayNCsO0cX/5Tl6BojOqNaxtsUKsGzVPszp8AuhN1C7y2PSVS19bqk6uIGy+QPH3QyM hTUxJrCcr/fr6zxyW3H9aZrEyf4aiiUEV3WDDJm1tMwtFT8xJtK7fguFtcwia8bvUK79RP eKB/BBGHt1PeOD/80WSIPAoo1e9YoOcq8Z7UsI3URZUNnOPjgZOXE0PVkGPvgsakg15WmX LqzTAK9SfG0Y2rb+fPRkeVhm00alDfgB3vWHsmCpnNCG1/3hC7Y+DxDmaSzhKRDwx44mr1 OGBQYzM3InytwvbXsmYRhJhnBIOcA3MJeEh2BJs7c3EJBHkQTT1ia25vCPQKJw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774159360; a=rsa-sha256; cv=none; b=H97j8XdB/Nk6HTaFOWy9tuHCuVAukMHY281ZBDS/JwYzN+QGfwvcEIGNYXSVcx2dXG9qSm InbdNNyl0Wnq0Z7wUyhpTT5m+kwO0h2X00ETQqjXtdmh1bTtUXdansGW3ZsaIRLXXLdBXs 2yph2R6cq9IPdUEJDVor6zDxm/KAdR7a324ZxjTHmpQDaVYEoQ+q1X5mb6VhWbwtUaXgok fvLlCIXltmRN64I0bolxWWjJZlIQpMJPJLrnEewPc/cKQxVJvbcHjW36XP3Dl8u3dD/woS aAFL2aFiffuxSk38YiJBBR+v53TrnU9e2Kbegdb9AWmx5Skxzfv/lEILWmWtFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774159360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CmbMpddH4hjkGc2mZy+cR4MAQgf954dTzIn52B3FWw8=; b=LC6GcsLrAlsSvET4BWj3OmQBiTFRrQbCY8SJCGweRKzAbkHNGieknYG19tX3Zd6dT7LVEM k7XvumAqEBzvlyCKjp2vMm3JKfwGinLr6gJrUWnW+n3iAwEySlhB42oQBb6+NBpldiU9S2 PZluLHaYl5NQUohaIl5Zp/ia7cq1/w+npQdBEZKL8+qbXd6psNvAcSsh96n4uuHV0BSqMm 48NQBMxZvEXjiAEM6RB61GApjCxf7mI39WqgK2ZC9Bjc/zveKC9vAeeN37BSU9pk2xv3V/ 0Z2zA21GZCrdNL01qGLwFfrYYBD4LU0DSDBhtP+nhngFdyQUtR72wfd8GHxp6g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fdm1C6cbPzms5 for ; Sun, 22 Mar 2026 06:02:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 347bf by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 22 Mar 2026 06:02:34 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 0b0d34fd2f40 - main - pf tests: verify first-match-wins for nat rules List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0b0d34fd2f40e06e4600441b15b26b1cc1941c9f Auto-Submitted: auto-generated Date: Sun, 22 Mar 2026 06:02:34 +0000 Message-Id: <69bf85fa.347bf.2555cd35@gitrepo.freebsd.org> The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=0b0d34fd2f40e06e4600441b15b26b1cc1941c9f commit 0b0d34fd2f40e06e4600441b15b26b1cc1941c9f Author: Kristof Provost AuthorDate: 2026-03-20 03:16:57 +0000 Commit: Kristof Provost CommitDate: 2026-03-22 03:47:36 +0000 pf tests: verify first-match-wins for nat rules Sponsored by: Orange Business Services --- tests/sys/netpfil/pf/nat.sh | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/tests/sys/netpfil/pf/nat.sh b/tests/sys/netpfil/pf/nat.sh index 025471f75f97..600688a8dbc9 100644 --- a/tests/sys/netpfil/pf/nat.sh +++ b/tests/sys/netpfil/pf/nat.sh @@ -953,6 +953,50 @@ dummynet_mask_cleanup() pft_cleanup } +atf_test_case "first_match" "cleanup" +first_match_head() +{ + atf_set descr 'Test that NAT rules are first match' + atf_set require.user root +} + +first_match_body() +{ + pft_init + + epair_nat=$(vnet_mkepair) + epair_echo=$(vnet_mkepair) + + vnet_mkjail nat ${epair_nat}b ${epair_echo}a + vnet_mkjail echo ${epair_echo}b + + ifconfig ${epair_nat}a 192.0.2.2/24 up + route add -net 198.51.100.0/24 192.0.2.1 + + jexec nat ifconfig ${epair_nat}b 192.0.2.1/24 up + jexec nat ifconfig ${epair_echo}a 198.51.100.1/24 up + jexec nat sysctl net.inet.ip.forwarding=1 + + jexec echo ifconfig ${epair_echo}b 198.51.100.2/24 up + + # Enable pf! + jexec nat pfctl -e + pft_set_rules nat \ + "table { 192.0.2.0/24 }" \ + "nat on ${epair_echo}a inet from to any -> 198.51.100.1" \ + "nat on ${epair_echo}a inet from 192.0.2.0/24 to any -> 198.51.100.3" + + atf_check -s exit:0 -o ignore ping -c 3 198.51.100.2 + atf_check -s exit:0 -e ignore \ + -o match:"all icmp 198.51.100.1:.*(192.0.2.2:.*) -> 198.51.100.2:8.*" \ + jexec nat pfctl -ss +} + +first_match_cleanup() +{ + pft_cleanup +} + atf_init_test_cases() { atf_add_test_case "exhaust" @@ -975,4 +1019,5 @@ atf_init_test_cases() atf_add_test_case "binat_match" atf_add_test_case "empty_pool" atf_add_test_case "dummynet_mask" + atf_add_test_case "first_match" }