From owner-cvs-all Tue Dec 14 8:17:17 1999 Delivered-To: cvs-all@freebsd.org Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38]) by hub.freebsd.org (Postfix) with ESMTP id 7E9FF14FED; Tue, 14 Dec 1999 08:17:13 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (root@d60-025.leach.ucdavis.edu [169.237.60.25]) by relay.nuxi.com (8.9.3/8.9.3) with ESMTP id IAA13761; Tue, 14 Dec 1999 08:17:12 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.9.3/8.9.1) id IAA85993; Tue, 14 Dec 1999 08:17:06 -0800 (PST) (envelope-from obrien) Date: Tue, 14 Dec 1999 08:17:06 -0800 From: "David O'Brien" To: Sheldon Hearn Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/chown Makefile Message-ID: <19991214081706.A85970@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG References: <40554.945171891@axl.noc.iafrica.com> <41621.945174529@axl.noc.iafrica.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <41621.945174529@axl.noc.iafrica.com>; from sheldonh@uunet.co.za on Tue, Dec 14, 1999 at 02:28:49PM +0200 X-Operating-System: FreeBSD 4.0-CURRENT Organization: The NUXI BSD group X-PGP-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Keyid: 34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Tue, Dec 14, 1999 at 02:28:49PM +0200, Sheldon Hearn wrote: > > - chown root.wheel "$1" > > + chown root.wheel "$1" || exit 1 > > I think the correct fix here would have been to revert that change, > rather than shuffling binaries around unnecessarily. That would be fine. BUT, we should issue a warning that the device node should be re-MAKEDEV'ed once multi-user. Otherwise there could be a security issue [I am not sure what the owner:group will be w/o the `chown']. Not erroring out, or warning the user to re-run MAKEDEV with /usr mounted can create a bad configuration. -- -- David (obrien@NUXI.com) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message