From owner-freebsd-bugs@FreeBSD.ORG Sat Feb 16 07:10:01 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 64438D97 for ; Sat, 16 Feb 2013 07:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 52FA6D6A for ; Sat, 16 Feb 2013 07:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r1G7A10B008350 for ; Sat, 16 Feb 2013 07:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r1G7A1UI008349; Sat, 16 Feb 2013 07:10:01 GMT (envelope-from gnats) Date: Sat, 16 Feb 2013 07:10:01 GMT Message-Id: <201302160710.r1G7A1UI008349@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Christoph Mallon Subject: Re: gnu/175985: [PATCH] Improve send-pr X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Christoph Mallon List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Feb 2013 07:10:01 -0000 The following reply was made to PR gnu/175985; it has been noted by GNATS. From: Christoph Mallon To: Eitan Adler Cc: bug-followup Subject: Re: gnu/175985: [PATCH] Improve send-pr Date: Sat, 16 Feb 2013 08:04:16 +0100 On 15.02.2013 19:25, Eitan Adler wrote: > On 9 February 2013 08:50, Christoph Mallon wrote: > > I have not yet looked at the code. > >>> Description: >> - Do not delete lines starting with Subject:. >> They are most probably part of a attached git patch. > > This is probably fine, but I am curious why they were removed in the > past. How does GNATS actually treat the subject line? There is no Subject line in the PR template presented to the user. After the user finishes filling out the PR template, send-pr adds a Subject line with a copy of the Synopsis. I guess, GNATS shows the Subject just like any other field. send-pr ensures, that Subject and Synopsis are the same (Have a look at some random PRs). >> - Recognize an empty file as a not filled out PR, too. > > This is fine with me. >> - Allow attaching files via -- followed by file names. > > This is fine with me. I also have another patch, which adds a dummy file after each file. GNATS does not recognize every other file. This works around the problem. The proper solution would be to correct the problem in GNATS. Christoph