From owner-svn-src-head@freebsd.org Wed May 25 15:51:49 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F35CB49365; Wed, 25 May 2016 15:51:49 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 3206A17DC; Wed, 25 May 2016 15:51:49 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u4PFpewg006305; Wed, 25 May 2016 08:51:44 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <201605251551.u4PFpewg006305@gw.catspoiler.org> Date: Wed, 25 May 2016 08:51:40 -0700 (PDT) From: Don Lewis Subject: Re: svn commit: r300685 - head/sbin/camcontrol To: src-committers@freebsd.org cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org In-Reply-To: <201605251543.u4PFh146077085@repo.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 15:51:49 -0000 On 25 May, To: src-committers@freebsd.org wrote: > Author: truckman > Date: Wed May 25 15:43:01 2016 > New Revision: 300685 > URL: https://svnweb.freebsd.org/changeset/base/300685 > > Log: > Fix a couple of new instances of a false positive Coverity buffer > overflow defect. Use the new CCB_CLEAR_ALL_EXCEPT_HDR() macro > instead of the calling bzero() on the pointer to the header used > as an array and indexed by 1. > > Don't leak a buffer after executing "goto restart_report" by > overwriting its pointer with the results of another calloc(). > Be sure to clear the buffer before reusing it. (CID 1356042) > > Reported by: Coverity > CID: 1356022, 1356034, 1356023, 1356035, 1356042 > Reviewed by: ken Differential Revision: https://reviews.freebsd.org/D6558