From owner-svn-src-projects@FreeBSD.ORG Thu Jun 18 10:20:40 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A3EB106566C; Thu, 18 Jun 2009 10:20:40 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id F3CE58FC17; Thu, 18 Jun 2009 10:20:37 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id NAA14406; Thu, 18 Jun 2009 13:03:02 +0300 (EEST) (envelope-from avg@freebsd.org) Message-ID: <4A3A10D5.8000601@freebsd.org> Date: Thu, 18 Jun 2009 13:03:01 +0300 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.21 (X11/20090406) MIME-Version: 1.0 To: Brooks Davis References: <200906171940.n5HJerMr086037@svn.freebsd.org> In-Reply-To: <200906171940.n5HJerMr086037@svn.freebsd.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r194389 - projects/ngroups/sys/kern X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2009 10:20:40 -0000 on 17/06/2009 22:40 Brooks Davis said the following: > Author: brooks > Date: Wed Jun 17 19:40:53 2009 > New Revision: 194389 > URL: http://svn.freebsd.org/changeset/base/194389 > > Log: > use MIN() instead of min() in one case. I think 'what' was pretty obvious from the diff, 'why' is what I am curious about :-) Just trying to learn something. > Modified: > projects/ngroups/sys/kern/kern_prot.c > > Modified: projects/ngroups/sys/kern/kern_prot.c > ============================================================================== > --- projects/ngroups/sys/kern/kern_prot.c Wed Jun 17 19:01:47 2009 (r194388) > +++ projects/ngroups/sys/kern/kern_prot.c Wed Jun 17 19:40:53 2009 (r194389) > @@ -1899,7 +1899,7 @@ cru2x(struct ucred *cr, struct xucred *x > xcr->cr_version = XUCRED_VERSION; > xcr->cr_uid = cr->cr_uid; > > - ngroups = min(cr->cr_ngroups, XU_NGROUPS); > + ngroups = MIN(cr->cr_ngroups, XU_NGROUPS); > xcr->cr_ngroups = ngroups; > bcopy(cr->cr_groups, xcr->cr_groups, > ngroups * sizeof(*cr->cr_groups)); -- Andriy Gapon