From owner-cvs-all@FreeBSD.ORG Mon Aug 15 12:56:04 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 228E916A41F; Mon, 15 Aug 2005 12:56:02 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.3/8.13.1) with ESMTP id j7FCwGfu004887; Mon, 15 Aug 2005 08:58:19 -0400 (EDT) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.3/8.13.1/Submit) id j7FCwE4u004886; Mon, 15 Aug 2005 08:58:14 -0400 (EDT) (envelope-from green) Date: Mon, 15 Aug 2005 08:58:14 -0400 From: Brian Fundakowski Feldman To: Pawel Jakub Dawidek Message-ID: <20050815125814.GC2660@green.homeunix.org> References: <200508120005.j7C05ARc090857@repoman.freebsd.org> <20050815053757.GB2660@green.homeunix.org> <20050815070033.GA8368@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050815070033.GA8368@garage.freebsd.pl> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/label g_label.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2005 12:56:04 -0000 On Mon, Aug 15, 2005 at 09:00:33AM +0200, Pawel Jakub Dawidek wrote: > On Mon, Aug 15, 2005 at 01:37:57AM -0400, Brian Fundakowski Feldman wrote: > +> On Fri, Aug 12, 2005 at 12:05:09AM +0000, Pawel Jakub Dawidek wrote: > +> > pjd 2005-08-12 00:05:09 UTC > +> > > +> > FreeBSD src repository > +> > > +> > Modified files: > +> > sys/geom/label g_label.c > +> > Log: > +> > Avoid creating directories in devfs by changing all '/' in labels to '_'. > +> > > +> > Idea from: Stanislav Sedov > +> > MFC after: 3 days > +> > +> Why would we want to prevent the usage of a specific directory structure > +> to represent GEOM's namespace, if that's what the administrator wants? > > If the label name is 'foo/bar' it doesn't seems right to create 'foo' > directory and provider 'bar' inside. The label could be also '../random' > or something like this and I want to save administrator/user nasty surprises > when he inserts some random CD. I like the idea of rejecting the latter, but what is the harm of the first case? If I call something "foo/bar", I'll be surprised to find out that it's located at /dev/foo_bar... my preference would be for the name to be rejected completely instead of remapped, if a '/' is to not be allowed, but that's my own. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\