From nobody Mon Jun 17 14:14:59 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W2sN341qHz5Ny1q for ; Mon, 17 Jun 2024 14:14:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W2sN270Lzz4tKX for ; Mon, 17 Jun 2024 14:14:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1718633699; a=rsa-sha256; cv=none; b=y1uzuH4mUv4pLTT51ipwhCPzVfgJDUlk+7uW99+QV8/5VZBKB4V9IBCY8q/FMBWJoCxb3q SkEdT0umE0p9WpSx37wvGw+D8oIkA6ttshIZg/4X7Qu4rbimrR8lwDUue33J5eUPSBVZ66 fE98na+9es7HWefVQoAXhQPBLUppH3gTBf0dDkvBtnjuSuF0sW3dHx8TuDnILzJWralup0 T4CbtXEwCUxLzrZca1DcHl1dRGGQQm0629w3wKoJ+7RIk4u/H5JyZfH0hPSOy1+9kmjyhJ Aq2fh4i7LjFQErxXn/xXoqkIA6hH0raNEL4R27PIPjO8zrw4gSnx7w14FLZagg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718633699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pxSkr/wgqbzYsYH5dE9BDqcmuWh4auNMDVAq8PlFdYU=; b=TlT7BeaE7PJ1mQSJiCjKUNfqN16TOTotFx7zNkve/BxTf+BfgBPx3FzLElKL44iA0GL6am rDzbo/QR8eySnHBpqjM1BX31ecJtC2fVzDhj09fPT0apyyIS2HZrk6zojP3LqtWypxSU4a PW9JAbSyMFubxqUGOofjiVh7lQWFi6jD95O8Tdir+QAekPL27rINx34jwBEAzp+ooN8ior g96aQe5JVa1Sno8MShJlhLW+G4euezcS6qyKo3CJjL+DvQ61sFxFu/PANaS0dHm6MYZ8VM RXTVlJPntRlltJo63vZc1QoZ+FjsAPsrQpIacaE1M5STJ/x3b32aWkgNwVltDA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4W2sN26ZJRzJdP for ; Mon, 17 Jun 2024 14:14:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 45HEEwGm021207 for ; Mon, 17 Jun 2024 14:14:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 45HEEwT0021206 for ports-bugs@FreeBSD.org; Mon, 17 Jun 2024 14:14:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 279816] Avoid defaulting to GH when USE_GITLAB and USE_GITHUB=nodefault is set Date: Mon, 17 Jun 2024 14:14:59 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: brd@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D279816 Bug ID: 279816 Summary: Avoid defaulting to GH when USE_GITLAB and USE_GITHUB=3Dnodefault is set Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Ports Framework Assignee: portmgr@FreeBSD.org Reporter: brd@FreeBSD.org CC: ports-bugs@FreeBSD.org Created attachment 251525 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D251525&action= =3Dedit patch When debugging some fetch failures I noticed that my port was always trying= to fetch from github instead of gitlab when USE_GITLAB and USE_GITHUB=3Dnodefa= ult is set. This appears to be because we check that MASTER_SITES is empty before USE_GITLAB has a chance to be run. The attached patch modifies the logic so that USE_GITHUB=3Dnodefault is che= cked even if MASTER_SITES is empty so that USE_GITLAB can populate it later. --=20 You are receiving this mail because: You are on the CC list for the bug.=