From nobody Sun Jul 19 13:40:54 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h34YJ0lyRz6mDvf for ; Sun, 19 Jul 2026 13:41:08 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h34YH556rz3dV1 for ; Sun, 19 Jul 2026 13:41:07 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso5058594f8f.1 for ; Sun, 19 Jul 2026 06:41:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784468466; x=1785073266; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5vrsBJY+K0tlh7DyORT6vO1ml6EUBfJSH3RcxyzdvsI=; b=ZNdp6HT9itVOMN4PiDxsxpcb46S9LeukxsXBBR3v5/7XuG4H3KEyyaXvtTF0V2NZni 1cJEFwdHQm8Ak48QHcYRyWOU8g4YS15AahaBro4aUUEbkR5RiUd4VzAWZjgNOmzjZAIH kGGu4PjEoI7x6IUi/H90eHDuc0RjL5RXFpafxLbxwSFXoPSu7UGuqjhl/OxPxIYeQFyg Ch9Um41gj+cQkMTpACUoHrTsqJxIdggX5qwETWcz7J71fdRlGletVkEn/tDcVUykmJSI XSy51MwFcU93OhlcMM9vvWeMq8GacHLufpbpqxIANchP7Qs6wjPRh0pqY1fvtjtpLuSw 4iOg== X-Forwarded-Encrypted: i=1; AHgh+RoVQ3Iz5kdPq9TwJNI5OGm11DQ6qi4Hg9OQs+BPrEETlJesCtRWgFSasNEAjqXxLK0GA1kao/tr+h40QlgvWlMeBX2C@freebsd.org X-Gm-Message-State: AOJu0Yxb0xjRRMLeEtfklRJJZbvnwMdxeoHnltcScDut0yCvFGlZheBL FF1gaMWQWecDMgSD4IJaz6aYFt9fd4DNsYm6Hey+JPUIEesKaGtoGZRunKRrzOLouIw= X-Gm-Gg: AfdE7clgTq3BsGrN7KOARmYhnbGFbd8/wv76AuIxDBg+c2DgE6Zot+n8U0cdI0pG2iM RRB5LSvYnpZpMAMTDEYpJLsRVCBD169w5dLSIF1yI84A9xarLvQDzw8rcQ6Rs4RkCTRhAklKBDw WIYH1xE/29qJZHTvOQ/RlE9uuMg4I6fxB7dpYIHdLZlks4SmPl/hXsa00CQLu8TV4Ppc8Y2UYum 5lwtNi6TeruKGkKhIN4yTdRPqpklCWdR1+373Jv2jErX9uZAD5fa7wq1GIkAYNVNA44oCSqll9m nOP5NeNDAsxRTxa5x6A97GzIWzma53+6LB0zoNM1gSBEPL5tynH2YL9pDEBV9b4t+1X/ZtAOFEf PBxkTYNB21HpanSGB3yRAXJNnDmpW6pPhQvRPLbxR3V++YkZFfB4RLJumqJVKRERyDK5i0KCIal 2axMgq9vAPp2wmQgK4hI/UZFlUhXDEU8IkL83DlbgJQXzI5x7QrxTZCgRcO/Y= X-Received: by 2002:a05:6000:4383:b0:47f:7047:5fba with SMTP id ffacd0b85a97d-47f70476122mr4693981f8f.42.1784468465633; Sun, 19 Jul 2026 06:41:05 -0700 (PDT) Received: from smtpclient.apple (nat-184-161.net.cam.ac.uk. [131.111.184.161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63e65644sm20201471f8f.16.2026.07.19.06.41.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jul 2026 06:41:04 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3893.100.7.1.1\)) Subject: Re: git: bdc0f7678257 - main - hwpstate_intel: Fix i386 build From: Jessica Clarke In-Reply-To: <6a5cd2fb.3bcc6.f82cb9f@gitrepo.freebsd.org> Date: Sun, 19 Jul 2026 14:40:54 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Harry Schmalzb Content-Transfer-Encoding: quoted-printable Message-Id: References: <6a5cd2fb.3bcc6.f82cb9f@gitrepo.freebsd.org> To: ShengYi Hung X-Mailer: Apple Mail (2.3893.100.7.1.1) X-Rspamd-Queue-Id: 4h34YH556rz3dV1 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Spamd-Bar: ---- On 19 Jul 2026, at 14:36, ShengYi Hung wrote: >=20 > The branch main has been updated by aokblast: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dbdc0f7678257eaa739b9c81628550447= 0e71e3de >=20 > commit bdc0f7678257eaa739b9c816285504470e71e3de > Author: Harry Schmalzb > AuthorDate: 2026-07-13 05:29:34 +0000 > Commit: ShengYi Hung > CommitDate: 2026-07-19 13:36:00 +0000 >=20 > hwpstate_intel: Fix i386 build >=20 > Reviewed by: olce > Fixes: 7b26353a59d6 > MFC after: 3 days > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D58208 > --- > sys/x86/cpufreq/hwpstate_intel.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/sys/x86/cpufreq/hwpstate_intel.c = b/sys/x86/cpufreq/hwpstate_intel.c > index 59d7a155fda8..56a33fa88e66 100644 > --- a/sys/x86/cpufreq/hwpstate_intel.c > +++ b/sys/x86/cpufreq/hwpstate_intel.c > @@ -352,13 +352,19 @@ intel_hwpstate_hybrid_cb(void *ctx) > { > uint32_t *small_cores =3D ctx; >=20 > +#ifdef __i386__ > + (void)small_cores; > +#else > atomic_add_32(small_cores, PCPU_GET(small_core)); > +#endif > } Hi, The whole point of my suggestion was that this would be the only part of the diff needed. By stubbing out the function, small_cores is never incremented, and so the code ifndef=E2=80=99ed out below is dead without = the need for as many ifndefs. Jessica > void > intel_hwpstate_identify(driver_t *driver, device_t parent) > { > +#ifndef __i386__ > uint32_t small_cores =3D 0; > +#endif >=20 > if (device_find_child(parent, "hwpstate_intel", DEVICE_UNIT_ANY) !=3D = NULL) > return; > @@ -379,6 +385,7 @@ intel_hwpstate_identify(driver_t *driver, device_t = parent) > if ((cpu_power_eax & CPUTPM1_HWP) =3D=3D 0) > return; >=20 > +#ifndef __i386__ > /* > * On hybrid-core systems, package-level control cannot be used. > * It may cause all cores to run at the E-core frequency because > @@ -389,6 +396,7 @@ intel_hwpstate_identify(driver_t *driver, device_t = parent) > intel_hwpstate_hybrid_cb, smp_no_rendezvous_barrier, &small_cores); > if (small_cores > 0 && small_cores < mp_ncores) > hwpstate_pkg_ctrl_enable =3D false; > +#endif >=20 > if (BUS_ADD_CHILD(parent, 10, "hwpstate_intel", = device_get_unit(parent)) > =3D=3D NULL) >=20