From owner-freebsd-qa@FreeBSD.ORG  Thu Apr 15 14:10:18 2004
Return-Path: <owner-freebsd-qa@FreeBSD.ORG>
Delivered-To: freebsd-qa@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CAC7516A4CE
	for <qa@hub.freebsd.org>; Thu, 15 Apr 2004 14:10:18 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BE9CB43D41
	for <qa@hub.freebsd.org>; Thu, 15 Apr 2004 14:10:18 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.10/8.12.10) with ESMTP id i3FLAIbv019945
	for <qa@freefall.freebsd.org>; Thu, 15 Apr 2004 14:10:18 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i3FLAIoM019944;
	Thu, 15 Apr 2004 14:10:18 -0700 (PDT)
	(envelope-from gnats)
Date: Thu, 15 Apr 2004 14:10:18 -0700 (PDT)
Message-Id: <200404152110.i3FLAIoM019944@freefall.freebsd.org>
To: qa@FreeBSD.org
From: Cyrille Lefevre <cyrille.lefevre@laposte.net>
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation
	time
X-BeenThere: freebsd-qa@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Cyrille Lefevre <cyrille.lefevre@laposte.net>
List-Id: FreeBSD Quality Assurance <freebsd-qa.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-qa>
List-Post: <mailto:freebsd-qa@freebsd.org>
List-Help: <mailto:freebsd-qa-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2004 21:10:18 -0000

The following reply was made to PR bin/27483; it has been noted by GNATS.

From: Cyrille Lefevre <cyrille.lefevre@laposte.net>
To: freebsd gnats <freebsd-gnats-submit@freebsd.org>
Cc:  
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time
Date: Thu, 15 Apr 2004 23:06:34 +0200

 well, RunningAsInit is effectively more appropriate than getpid() == 1.
 
 Index: main.c
 ===================================================================
 RCS file: /home/ncvs/src/usr.sbin/sysinstall/main.c,v
 retrieving revision 1.71
 diff -u -I$Id.*$ -I$.+BSD.*$ -r1.71 main.c
 --- main.c	20 Aug 2003 06:27:21 -0000	1.71
 +++ main.c	15 Apr 2004 21:03:33 -0000
 @@ -166,6 +166,8 @@
  
      /* Begin user dialog at outer menu */
      dialog_clear();
 +    if (RunningAsInit)
 +        dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FALSE);
      while (1) {
  	choice = scroll = curr = max = 0;
  	dmenuOpen(&MenuInitial, &choice, &scroll, &curr, &max, TRUE);
 
 Cyrille Lefevre
 -- 
 mailto:cyrille.lefevre@laposte.net