From owner-svn-src-all@freebsd.org  Tue Aug 11 14:07:25 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3BD3699F14D
 for <svn-src-all@mailman.ysv.freebsd.org>;
 Tue, 11 Aug 2015 14:07:25 +0000 (UTC) (envelope-from ed@nuxi.nl)
Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com
 [209.85.218.47])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0DBC930E
 for <svn-src-all@freebsd.org>; Tue, 11 Aug 2015 14:07:24 +0000 (UTC)
 (envelope-from ed@nuxi.nl)
Received: by oihn130 with SMTP id n130so105873381oih.2
 for <svn-src-all@freebsd.org>; Tue, 11 Aug 2015 07:07:17 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=jOhQB3mqJCFeqdTDt23yO5ZE9WbrJlvRfgKTlYpYmoI=;
 b=ikkTIlT9wxdXHLUXxMUKis/8N8tLQAD9jMo5MEu2A+/PgzOemOQMA6adxgmvV0xUBc
 7gIotf+yrTA6SJH14VtAJCwnyb32m7pQLqHt5Uu58NEVcFjZ5f7K5v1jGcF514YXaIXy
 t4tUJ465Nit+f7G1Ygz6k1ltKRxZlwMiNqDcrFdRVtZkxi2H3yi2yHXFpZY6JuTuwzji
 JoRwTbL1+fAd4M0+7DOWxHLaTs2YPYrpwDRAfsA+0F/qPveHuiXkW4QYzLPAMpJAnBt1
 XMXO3ysenbECxzHT4LPbbJrqd/WKVc/aOMnuIzEsJJSBJHPRFFlWv1yThJdJoljOhNIT
 56WQ==
X-Gm-Message-State: ALoCoQkVwDF3OEszVJCdgjk+/TI1hvuVpSRuS152/K7u/XQo4OJDquLuJ4IeKuV8BxpEVkxGSaYq
MIME-Version: 1.0
X-Received: by 10.202.208.136 with SMTP id h130mr7426188oig.74.1439301715413; 
 Tue, 11 Aug 2015 07:01:55 -0700 (PDT)
Received: by 10.76.50.84 with HTTP; Tue, 11 Aug 2015 07:01:55 -0700 (PDT)
X-Originating-IP: [84.27.222.46]
In-Reply-To: <201508091258.t79CwvGj027161@repo.freebsd.org>
References: <201508091258.t79CwvGj027161@repo.freebsd.org>
Date: Tue, 11 Aug 2015 16:01:55 +0200
Message-ID: <CABh_MK=HiU-xNu1woz6koPxqtSjOb0rNXKxj=0gENkD44CkcAg@mail.gmail.com>
Subject: Re: svn commit: r286524 - in head: . etc sys/dev/drm sys/dev/drm2
From: Ed Schouten <ed@nuxi.nl>
To: Koop Mast <kwm@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Aug 2015 14:07:25 -0000

Hi Koop,

2015-08-09 14:58 GMT+02:00 Koop Mast <kwm@freebsd.org>:
> +#define DRM_DEV_GID    44      /* "video" group */

I think it looks a bit weird that DRM has these definitions locally.
<sys/conf.h> already has definitions for various users and groups
(UID_* and GID_*). Would it make sense to add GID_VIDEO to
<sys/conf.h> and change the definitions in drmP.h to the following?

#define DRM_DEV_UID UID_ROOT
#define DRM_DEV_GID GID_VIDEO

-- 
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717