From owner-svn-src-head@freebsd.org Sun Feb 25 01:02:07 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03B02F3207A; Sun, 25 Feb 2018 01:02:07 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com [209.85.223.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9531980B7B; Sun, 25 Feb 2018 01:02:06 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f178.google.com with SMTP id e30so3123891ioc.3; Sat, 24 Feb 2018 17:02:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=yMVQ1JtTwwCBl3p4pS1C/TaKmqJUu10P3yrspRW+n6w=; b=nChsX/H0BUlKyBGi06KX8kTgwvU3q0EYmBTQn4QnDzoDtPoOt5CrYm2D2PKZVBVdY7 URUS1Wvk+VkOFjzrTsUi0gLyotxIy8M4vkDlsloFuSImX/lj+ZBsHm6HnOfsZtsAPhGB nSkKCws+iQvX5TlWQ/nHPwMBqxbmzbJlkTz2TIzrkryrLz2txNHVB4qR+b//FWpM5Xj2 xULHDZmEWZHOKIVjTBay1ldWycOEjJFjlta5w0hbRp6qRvX0lV9Zf95tpFE951mJa6ka xMnKiSx8RyckF5BJjfsuKMCbs5iNQSQ9Lt5eAb6kF3TWxePtFWXqoHKlwhr/yN/h5QCs 3d+g== X-Gm-Message-State: APf1xPB5kYKblIgdukNnBgtGT2nQQeOSh/Df+Mfb3ggDL+8AvH6MFdTE A5s1VbNiwG7O9/jPTLc53z8rH/Bf X-Google-Smtp-Source: AG47ELsGyMQuwqthT0n/B2lARXX+eIk9xYT1ziY1WGSPUX4WBAAAsopahDJtUJI2Bc+W5lttguLBVg== X-Received: by 10.107.132.227 with SMTP id o96mr7368340ioi.58.1519520519830; Sat, 24 Feb 2018 17:01:59 -0800 (PST) Received: from mail-it0-f47.google.com (mail-it0-f47.google.com. [209.85.214.47]) by smtp.gmail.com with ESMTPSA id 5sm3231441itb.36.2018.02.24.17.01.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Feb 2018 17:01:59 -0800 (PST) Received: by mail-it0-f47.google.com with SMTP id k79so4347025ita.2; Sat, 24 Feb 2018 17:01:59 -0800 (PST) X-Received: by 10.36.92.205 with SMTP id q196mr7920263itb.135.1519520519588; Sat, 24 Feb 2018 17:01:59 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.30.149 with HTTP; Sat, 24 Feb 2018 17:01:59 -0800 (PST) In-Reply-To: References: <201802211551.w1LFpn57042314@repo.freebsd.org> From: Conrad Meyer Date: Sat, 24 Feb 2018 17:01:59 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r329722 - head/cddl/usr.sbin/zdb To: Alan Somers Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Feb 2018 01:02:07 -0000 I did not see the array bounds error, but perhaps my build failed before it got to that point. Thanks for taking a look at it. Conrad On Sat, Feb 24, 2018 at 4:57 PM, Alan Somers wrote: > On Sat, Feb 24, 2018 at 5:19 PM, Conrad Meyer wrote: >> >> On Wed, Feb 21, 2018 at 8:40 PM, Alan Somers wrote: >> > On Wed, Feb 21, 2018 at 8:51 AM, Alan Somers >> > wrote: >> >> >> >> Author: asomers >> >> Date: Wed Feb 21 15:51:48 2018 >> >> New Revision: 329722 >> >> URL: https://svnweb.freebsd.org/changeset/base/329722 >> >> >> >> Log: >> >> zdb: raise WARNS from 0 to 2 >> >> >> >> This has only been possible since r329694 and r329508 >> >> >> >> MFC after: 3 weeks >> >> X-MFC-With: 329694 >> >> X-MFC-With: 329508 >> >> Sponsored by: Spectra Logic >> >> >> >> Modified: >> >> head/cddl/usr.sbin/zdb/Makefile >> >> >> > >> > Looks like I broke the build with GCC-6. >> >> Yep, I can confirm it's broken. I don't see a flag we can just turn >> off for the GCC warning, though, so the solution might have to be >> CFLAGS.gcc += -Wno-error. >> >> > I'll fix it, as soon as I can get >> > the toolchain setup. >> >> The easy way is just: >> >> $ pkg install amd64-xtoolchain-gcc >> $ make -sj$(sysctl -n hw.ncpu) buildworld CROSS_TOOLCHAIN=amd64-gcc >> >> Thanks, >> Conrad > > > > There seem to be 3 problems: CTASSERT, assfail, and array bounds. I've > already committed a fix for CTASSERT and I'm testing an assfail fix now. > The array bounds problem is harder, though. The logic is complicated, but I > think it's sound. I don't know why GCC is complaining, unless maybe it > thinks that an enum type is signed. If I can't find a good solution, I'll > set -Wno-error as you suggest. > > -Alan >