Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 May 2011 11:37:06 +0200
From:      Hans Petter Selasky <hselasky@c2i.net>
To:        Ilya Putsikau <ilya@freebsd.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   Re: PERFORCE change 193904 for review
Message-ID:  <201105301137.06276.hselasky@c2i.net>
In-Reply-To: <201105291108.p4TB8TNI081384@skunkworks.freebsd.org>
References:  <201105291108.p4TB8TNI081384@skunkworks.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 29 May 2011 13:08:29 Ilya Putsikau wrote:
> -       mtx_lock(&data->ticket_mtx);
> -       data->dataflag |= FSESS_INITED;
> -       wakeup(&data->ticketer);
> -       mtx_unlock(&data->ticket_mtx);
> +    mtx_lock(&data->ticket_mtx);
> +    data->dataflag |= FSESS_INITED;
> +    wakeup(&data->ticketer);
> +    mtx_unlock(&data->ticket_mtx);

Hi,

It is maybe an idea to make macros for frequencly used locking.

TICKET_LOCK(&data);

TICKET_UNLOCK(&data);

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201105301137.06276.hselasky>