From nobody Tue Oct 24 22:07:05 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SFR49394kz4xZh3; Tue, 24 Oct 2023 22:07:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SFR492KWCz3DRx; Tue, 24 Oct 2023 22:07:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698185225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bqLZIkCvPDU4hTeEFwzK5uU7AxVUkSD05P6oXnNsCQg=; b=rhM/h/8AxLZR10RnL5Kp3MrvPcH0qaSSuLXTH1o4hRvNYKJak6CF/IblnDuh0+8Jp/5g82 zgHz2iSx3kA36wGXQU4jLQLI0HHsgpr5JvRxuwbgTFCjvDfYndhsOV4upo+ijfHMAGo6EU dPjvpBPYzUS5cAiilaB2m6Csv146bw+QjUghTbpbqVsh9rQpvryPzToWZi4wLVJ1lR4AJD Ow6QAJcl/Zijx67uWc1jqr5RIOsjL2WzPsi6ucKpU7colVwmA6YR1Uq8sb+IBDo5zlSgJJ nl1snkJFdOUqDJM70LKxL1P7/DXTzyeyV71avdhNlfrntrVYqjaQMAJ0noDKWA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1698185225; a=rsa-sha256; cv=none; b=PXHEKflfyKF5xr4Wpw/po4KztEzMca25rNbczZ7P+GnvYxBVbev1kiuIaEpyqU+cOME+sc x9QCCTWJSjrKx0wTLfXwQWF6c478DJwNEhNpdiywBQIDWB/SfnJTDqqXM437lW/DJNBdmr X46kFAntxk1NdLgVCx4QT1fUw+AjbY9SM+fi0gc+nw6UKcJBGKJzkqWS3QY3H9X85hWrE5 brKWjZYrEQCl05i4RNZ0vx0cN+i4F2opToRCLasyVeUMlYITtlO6fOB0O3tAyCAZ+5G2Wt THuwqfhBbtPFPFECODUwqZy3mUAS9jKxDQK3jr/xMrYGbliwHy9OBRBbTJHl8A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698185225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bqLZIkCvPDU4hTeEFwzK5uU7AxVUkSD05P6oXnNsCQg=; b=oMSGE9UIlmWMCIy5JPWzc+7CFL14vWKr0ItwqtMDEHM/cM5eW3nY9mcR9C5JwZqqgkcrPi m1Dn5rVQWdqEKCvpSVQ1BCiIwy04Sr7iRtooce84qnBA4KM/Tr6u8sHkWamW6Id217BAMG 5tgN/GpqnnnavKEVv6d3+DikzEiEXc+brexY6/Uujs2oBkaaBRBoH3K6mqkMlwvDv+96ZT Hm8mzorQlMp0agMlP3awIXXGS0YhPLkG6FAtKTnt5/7zL5i8P/CguBx4GBcngfGAR8raTn gSWa0LpdVy+hFXAekUQnKXAHqOmmrE2KXKrhgkIUbIQI/31qVRMgcE0Xjy+OKQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SFR490s69zflr; Tue, 24 Oct 2023 22:07:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39OM75eq041757; Tue, 24 Oct 2023 22:07:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39OM75v9041754; Tue, 24 Oct 2023 22:07:05 GMT (envelope-from git) Date: Tue, 24 Oct 2023 22:07:05 GMT Message-Id: <202310242207.39OM75v9041754@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 1798b44fda38 - main - user stack randomization: only enable by default for 64bit processes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1798b44fda382c473c9fc7762e162613a39dc23c Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=1798b44fda382c473c9fc7762e162613a39dc23c commit 1798b44fda382c473c9fc7762e162613a39dc23c Author: Konstantin Belousov AuthorDate: 2023-10-24 21:44:06 +0000 Commit: Konstantin Belousov CommitDate: 2023-10-24 22:06:48 +0000 user stack randomization: only enable by default for 64bit processes All aslr knobs are disabled by default for 32bit processes, except stack. This results in weird stack location, typically making around 1G of user address space hard to use. Reviewed by: emaste Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D42356 --- sys/kern/imgact_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/imgact_elf.c b/sys/kern/imgact_elf.c index e01bccc93cb0..4ebd08082545 100644 --- a/sys/kern/imgact_elf.c +++ b/sys/kern/imgact_elf.c @@ -200,7 +200,7 @@ SYSCTL_INT(ASLR_NODE_OID, OID_AUTO, honor_sbrk, CTLFLAG_RW, &__elfN(aslr_honor_sbrk), 0, __XSTRING(__CONCAT(ELF, __ELF_WORD_SIZE)) ": assume sbrk is used"); -static int __elfN(aslr_stack) = 1; +static int __elfN(aslr_stack) = __ELF_WORD_SIZE == 64; SYSCTL_INT(ASLR_NODE_OID, OID_AUTO, stack, CTLFLAG_RWTUN, &__elfN(aslr_stack), 0, __XSTRING(__CONCAT(ELF, __ELF_WORD_SIZE))