From owner-cvs-all@FreeBSD.ORG Tue Apr 6 16:53:35 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EDB0016A4CE for ; Tue, 6 Apr 2004 16:53:35 -0700 (PDT) Received: from tx3.oucs.ox.ac.uk (tx3.oucs.ox.ac.uk [163.1.2.167]) by mx1.FreeBSD.org (Postfix) with ESMTP id 895BA43D4C for ; Tue, 6 Apr 2004 16:53:35 -0700 (PDT) (envelope-from colin.percival@wadham.ox.ac.uk) Received: from scan3.oucs.ox.ac.uk ([163.1.2.166] helo=localhost) by tx3.oucs.ox.ac.uk with esmtp (Exim 4.24) id 1BB0Mf-000140-Mh for cvs-all@FreeBSD.org; Wed, 07 Apr 2004 00:52:21 +0100 Received: from rx3.oucs.ox.ac.uk ([163.1.2.165]) by localhost (scan3.oucs.ox.ac.uk [163.1.2.166]) (amavisd-new, port 25) with ESMTP id 03596-09 for ; Wed, 7 Apr 2004 00:52:20 +0100 (BST) Received: from gateway.wadham.ox.ac.uk ([163.1.161.253]) by rx3.oucs.ox.ac.uk with smtp (Exim 4.24) id 1BB0Me-00013C-Ao for cvs-all@FreeBSD.org; Wed, 07 Apr 2004 00:52:20 +0100 Received: (qmail 2562 invoked by uid 1004); 6 Apr 2004 23:52:18 -0000 Received: from colin.percival@wadham.ox.ac.uk by gateway by uid 71 with qmail-scanner-1.20 (clamscan: 0.67. sweep: 2.18/3.79. Clear:RC:1(163.1.161.131):. Processed in 0.018735 secs); 06 Apr 2004 23:52:18 -0000 Received: from dhcp1131.wadham.ox.ac.uk (HELO piii600.wadham.ox.ac.uk) (163.1.161.131) by gateway.wadham.ox.ac.uk with SMTP; 6 Apr 2004 23:52:18 -0000 Message-Id: <6.0.1.1.1.20040407004244.03f85e80@imap.sfu.ca> X-Sender: cperciva@imap.sfu.ca (Unverified) X-Mailer: QUALCOMM Windows Eudora Version 6.0.1.1 Date: Wed, 07 Apr 2004 00:52:16 +0100 To: Nate Lawson From: Colin Percival In-Reply-To: <20040406162703.H30263@root.org> References: <20040406230958.C01C616A545@hub.freebsd.org> <20040406162703.H30263@root.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Colin Percival Subject: Re: cvs commit: src/sys/kern kern_timeout.c src/sys/sys callout.h src/share/man/man9 timeout.9 X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2004 23:53:36 -0000 At 00:32 07/04/2004, Nate Lawson wrote: >For this one, you can move the comment to above the "if" statement and add >a blank line before it. It's usually best to comment on the whole block >above the if statement rather than within it. Hmm... those comments are written in the context of the "if" blocks. Does it really make sense to replace if(foo) { /* Bar */ ... with /* If foo, then bar */ if(foo) { ... I'm generally happy to make style changes, but this seems like a rather peculiar change to make. >> int callout_stop(struct callout *); >> +#define callout_stop(c) _callout_stop_safe(c, 0) > >The goal here is to keep binary compatibility (multiple defines of >callout_stop)? The goal was binary compatibility; the callout_stop prototype was still here because gcc complained while compiling kern_timeout.c otherwise. If there's a better solution, please let me know. >Are you >going to remove that shim at some point? Perhaps a BURN_BRIDGES or >GONE_IN_6 ifdef would be appropriate for that. I think this shim can be removed as soon as any modules which know about callout_stop have been recompiled; I doubt it will take long before someone makes a change which requires that to happen. :-) Colin Percival