Date: Wed, 4 Jun 2003 18:30:08 -0700 (PDT) From: Lars Eggert <larse@nik.isi.edu> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/52956: Bugfix: net/p5-NetPacket Message-ID: <200306050130.h551U838099675@nik.isi.edu> Resent-Message-ID: <200306050140.h551eHCm065425@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 52956
>Category: ports
>Synopsis: Bugfix: net/p5-NetPacket
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jun 04 18:40:16 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator: Lars Eggert
>Release: FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:
System: FreeBSD nik.isi.edu 5.1-CURRENT FreeBSD 5.1-CURRENT #0: Tue Jun 3 10:18:46 PDT 2003 root@nik.isi.edu:/usr/obj/usr/src/sys/KERNEL-1.23 i386
>Description:
NetPacket::IP calculates the IP checksum incorrectly when sending
packets. The attached patch fixes this, has been submitted to the
authors and verified by them to fix the problem.
> From: Stephanie Wehner <_@r4k.net>
> To: Lars Eggert <larse@ISI.EDU>
> Subject: Re: NetPacket::IP bug (with patch)
>
> Hi Lars,
>
> Sorry for the late reply, quite busy lately :(
>
> > I think there's a small bug in NetPacket::IP - the wrong "offset"
> > variable is used when encoding a packet (see the included patch). Other
>
> Thanks for the patch ! I'll incorporate it tomorrow or on tuesday
> (along with some additions people submitted). I'll let you know
> when the new version's on cpan.
>
> bye,
> Stephanie
>How-To-Repeat:
>Fix:
diff -u -N -r np/Makefile p5-NetPacket/Makefile
--- np/Makefile Wed Jun 4 18:17:18 2003
+++ p5-NetPacket/Makefile Wed Jun 4 18:19:25 2003
@@ -7,6 +7,7 @@
PORTNAME= NetPacket
PORTVERSION= 0.03
+PORTREVISION= 1
CATEGORIES= net perl5
MASTER_SITES= ${MASTER_SITE_PERL_CPAN}
MASTER_SITE_SUBDIR= NetPacket
diff -u -N -r np/files/patch-aa p5-NetPacket/files/patch-aa
--- np/files/patch-aa Wed Dec 31 16:00:00 1969
+++ p5-NetPacket/files/patch-aa Wed Jun 4 18:18:37 2003
@@ -0,0 +1,12 @@
+--- NetPacket/IP.pm Fri Jan 11 20:10:25 2002
++++ NetPacket/IP.pm.new Fri Jan 11 20:10:35 2002
+@@ -224,7 +224,7 @@
+
+ # make the entire packet
+ $packet = pack('CCnnnCCna4a4a*a*', $tmp, $self->{tos},$self->{len},
+- $self->{id}, $self->{foffset}, $self->{ttl}, $self->{proto},
++ $self->{id}, $offset, $self->{ttl}, $self->{proto},
+ $self->{cksum}, $src_ip, $dest_ip, $self->{options},
+ $self->{data});
+
+
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200306050130.h551U838099675>