From owner-freebsd-audit Thu Jun 21 6:27:26 2001 Delivered-To: freebsd-audit@freebsd.org Received: from ringworld.nanolink.com (ringworld.nanolink.com [195.24.48.13]) by hub.freebsd.org (Postfix) with SMTP id 14BFF37B401 for ; Thu, 21 Jun 2001 06:27:20 -0700 (PDT) (envelope-from roam@orbitel.bg) Received: (qmail 13955 invoked by uid 1000); 21 Jun 2001 13:25:46 -0000 Date: Thu, 21 Jun 2001 16:25:46 +0300 From: Peter Pentchev To: Alexey Zelkin Cc: hackers@FreeBSD.org, audit@FreeBSD.org, bde@FreeBSD.org, ache@FreeBSD.org Subject: Re: whois(1) patch for review Message-ID: <20010621162546.I772@ringworld.oblivion.bg> Mail-Followup-To: Alexey Zelkin , hackers@FreeBSD.org, audit@FreeBSD.org, bde@FreeBSD.org, ache@FreeBSD.org References: <20010621160821.A30249@phantom.cris.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010621160821.A30249@phantom.cris.net>; from phantom@FreeBSD.org.ua on Thu, Jun 21, 2001 at 04:08:21PM +0300 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, Jun 21, 2001 at 04:08:21PM +0300, Alexey Zelkin wrote: > hi, > > I have made few modifications to whois(1) to shut up BDECFLAGS > warnings, cleanup code, and add new features. [snip] > > Resume: with this patch included to add new country's whois server > we'll need to add only one string to text file, not to modify > whois(1) code as it has been done by Andrey for '-R' and as > some pending PR's proposed to do. > > PS: I also removed -R switch for whois(1) which was used to point > to Russian whois server, since it is replaced with "-c ru" > > PPS: It's tested on STABLE, but I don't think that there can be problems > with -current. > > PPPS: Patch is dirty threfore any ideas on its cleanup are welcome. Also > additional idea on improving whois(1) flexibility are welcome! I hope to > get some free time on this weekend and commit it if nobody has strong > objections. > > http://phantom.cris.net/~phantom/whois_patch.tgz Wow. I think there's been a GREAT deal of duplication of effort over whois(1).. Have you looked at Mike Barcroft's patches, posted both as a PR and as a longish thread on -audit a couple of days ago, or at Joachim Strombergson's patches, posted as a longish thread on -audit a month or so ago? My understanding is that Mike Barcroft's patches remove the warnings, and Joachim Strombergson was working on the server list thing :) G'luck, Peter -- This sentence would be seven words long if it were six words shorter. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message