From owner-cvs-all@FreeBSD.ORG Wed Feb 15 15:18:27 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.ORG Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A11816A420; Wed, 15 Feb 2006 15:18:27 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3A2F43D5A; Wed, 15 Feb 2006 15:18:25 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id k1FFIOwe081584; Wed, 15 Feb 2006 17:18:24 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ip.net.ua [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 72021-01-5; Wed, 15 Feb 2006 17:18:00 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id k1FFF5Bh081469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 15 Feb 2006 17:15:06 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.4/8.13.4) id k1FFF9Qk096571; Wed, 15 Feb 2006 17:15:09 +0200 (EET) (envelope-from ru) Date: Wed, 15 Feb 2006 17:15:09 +0200 From: Ruslan Ermilov To: Gleb Smirnoff Message-ID: <20060215151508.GC96442@ip.net.ua> References: <200602151345.k1FDj2Aq013830@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ikeVEW9yuYc//A+q" Content-Disposition: inline In-Reply-To: <200602151345.k1FDj2Aq013830@repoman.freebsd.org> User-Agent: Mutt/1.5.11 X-Virus-Scanned: amavisd-new at ip.net.ua Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Feb 2006 15:18:27 -0000 --ikeVEW9yuYc//A+q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 15, 2006 at 01:45:02PM +0000, Gleb Smirnoff wrote: > glebius 2006-02-15 13:45:02 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/em if_em.c=20 > Log: > em_hardware_init() in em_init() is not needed, and leads to annoying > link flap. > =20 > Submitted by: ru, Mike Tancsa > =20 > Revision Changes Path > 1.112 +0 -7 src/sys/dev/em/if_em.c >=20 Hmm, I have abandoned this change locally, as it was causing me some problems I cannot fully recall now. Perhaps it was *NOT* reprogramming the receive filter on a MAC change, I don't remember. Since you committed it, can you please verify what exactly the em_hardware_init() does that can be useful in the if_init method? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --ikeVEW9yuYc//A+q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD80V8qRfpzJluFF4RAhKpAJoD2F8JdDj+5Bg/01a+hQRQhCq16gCcDETx yxAPIOdzsCbE0RCRH1HE5S0= =XRnn -----END PGP SIGNATURE----- --ikeVEW9yuYc//A+q--