From owner-svn-src-all@freebsd.org Tue Apr 19 17:27:54 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3DD4EB14A5C; Tue, 19 Apr 2016 17:27:54 +0000 (UTC) (envelope-from rb743@hermes.cam.ac.uk) Received: from ppsw-43.csi.cam.ac.uk (ppsw-43.csi.cam.ac.uk [131.111.8.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0A16D17FC; Tue, 19 Apr 2016 17:27:53 +0000 (UTC) (envelope-from rb743@hermes.cam.ac.uk) X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from xc1.bsdpad.com ([195.154.136.64]:26651) by ppsw-43.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.159]:587) with esmtpsa (LOGIN:rb743) (TLSv1:ECDHE-RSA-AES256-SHA:256) id 1asZRG-000349-oI (Exim 4.86_36-e07b163) (return-path ); Tue, 19 Apr 2016 18:27:50 +0100 Date: Tue, 19 Apr 2016 18:12:44 +0100 From: Ruslan Bukin To: Adrian Chadd Cc: Ruslan Bukin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r298274 - head/sys/dev/spibus Message-ID: <20160419171243.GA30453@bsdpad.com> References: <201604191539.u3JFdkHx048678@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: "R. Bukin" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2016 17:27:54 -0000 Why I added or why I reverted ? So once I started to work on generic MMC over SPI driver it was looking like MMC/SD device in harware requires to keep CS asserted during multiple transfers, but once I completed it is become clear hardware don't require that. Ruslan On Tue, Apr 19, 2016 at 09:40:23AM -0700, Adrian Chadd wrote: > Hm, why'd you do this? did you get it reviewed first? > > I'm about to write a kernel bitbang SPI driver that supports arbitrary > GPIOs, and I was thinking of fleshing this out somewhat. > > > > -adrian > > > On 19 April 2016 at 08:39, Ruslan Bukin wrote: > > Author: br > > Date: Tue Apr 19 15:39:46 2016 > > New Revision: 298274 > > URL: https://svnweb.freebsd.org/changeset/base/298274 > > > > Log: > > Revert r298268 (Add optional chip_select/deselect methods). > > None of supported hardware do require that. > > > > Modified: > > head/sys/dev/spibus/spibus.c > > head/sys/dev/spibus/spibus_if.m > > > > Modified: head/sys/dev/spibus/spibus.c > > ============================================================================== > > --- head/sys/dev/spibus/spibus.c Tue Apr 19 15:36:18 2016 (r298273) > > +++ head/sys/dev/spibus/spibus.c Tue Apr 19 15:39:46 2016 (r298274) > > @@ -185,24 +185,9 @@ spibus_hinted_child(device_t bus, const > > static int > > spibus_transfer_impl(device_t dev, device_t child, struct spi_command *cmd) > > { > > - > > return (SPIBUS_TRANSFER(device_get_parent(dev), child, cmd)); > > } > > > > -static int > > -spibus_chip_select_impl(device_t dev, device_t child) > > -{ > > - > > - return (SPIBUS_CHIP_SELECT(device_get_parent(dev), child)); > > -} > > - > > -static int > > -spibus_chip_deselect_impl(device_t dev, device_t child) > > -{ > > - > > - return (SPIBUS_CHIP_DESELECT(device_get_parent(dev), child)); > > -} > > - > > static device_method_t spibus_methods[] = { > > /* Device interface */ > > DEVMETHOD(device_probe, spibus_probe), > > @@ -223,8 +208,6 @@ static device_method_t spibus_methods[] > > > > /* spibus interface */ > > DEVMETHOD(spibus_transfer, spibus_transfer_impl), > > - DEVMETHOD(spibus_chip_select, spibus_chip_select_impl), > > - DEVMETHOD(spibus_chip_deselect, spibus_chip_deselect_impl), > > > > DEVMETHOD_END > > }; > > > > Modified: head/sys/dev/spibus/spibus_if.m > > ============================================================================== > > --- head/sys/dev/spibus/spibus_if.m Tue Apr 19 15:36:18 2016 (r298273) > > +++ head/sys/dev/spibus/spibus_if.m Tue Apr 19 15:39:46 2016 (r298274) > > @@ -39,19 +39,3 @@ METHOD int transfer { > > device_t child; > > struct spi_command *cmd; > > }; > > - > > -# > > -# Assert chip select > > -# > > -METHOD int chip_select { > > - device_t dev; > > - device_t child; > > -}; > > - > > -# > > -# Deassert chip select > > -# > > -METHOD int chip_deselect { > > - device_t dev; > > - device_t child; > > -}; > > >