From owner-svn-src-all@freebsd.org Tue May 3 22:23:05 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3FF3B2C8C6; Tue, 3 May 2016 22:23:05 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi0-f52.google.com (mail-oi0-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B34AB1F69; Tue, 3 May 2016 22:23:05 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi0-f52.google.com with SMTP id x19so44553443oix.2; Tue, 03 May 2016 15:23:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc:content-transfer-encoding; bh=wIOWMTd8VJx7nmpKGTFInxrtBqcsckiH7koSbJjZxXA=; b=bYtkgXucUGtKOzjFI4kfdzy8z63i8ifq+dJ5nfmxe9PWhdzm/X6ND7XNR4H8pj7PDq 1kxlOH7XV2wh2uXvMXF967U90jZb2CW3zR7O4Qunt7eJ8NDojgEereYD1Rnh+BZxqz/k SS6YPSP0HDzmK9z6o4gvj9EmDKPRnOnAaH9RMDk+UJOq3kR+5E76uPEpzdbHboyhgGkS 4ktxWGjBkhLQJoeSS3MGOUv5WehYS/d16OUW8mR6ivNFpI4nN39419YIrvv2abPBscZ5 d7WDHvbyY42WZphDtrftE4OSmBQurtpBsDunY+7C6mrqPdR7wL7ip/vqJSRL317BiI/1 iGUg== X-Gm-Message-State: AOPr4FV3aiMgcFqTI4k8WqWENNuZIZqKn/oFD4TiU2qSi1Iap8b8si4xUgunNTaRa0/QQw== X-Received: by 10.157.41.74 with SMTP id d68mr2536759otb.65.1462307932108; Tue, 03 May 2016 13:38:52 -0700 (PDT) Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com. [209.85.218.43]) by smtp.gmail.com with ESMTPSA id x4sm107262obs.0.2016.05.03.13.38.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 May 2016 13:38:51 -0700 (PDT) Received: by mail-oi0-f43.google.com with SMTP id x201so41585090oif.3; Tue, 03 May 2016 13:38:51 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.157.20.217 with SMTP id r25mr2561449otr.72.1462307931474; Tue, 03 May 2016 13:38:51 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.157.6.111 with HTTP; Tue, 3 May 2016 13:38:51 -0700 (PDT) In-Reply-To: References: <201604262059.u3QKxLDl045059@repo.freebsd.org> Date: Tue, 3 May 2016 13:38:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r298665 - head/sys/dev/aacraid From: Conrad Meyer To: Warner Losh Cc: Oliver Pinter , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2016 22:23:06 -0000 On Tue, May 3, 2016 at 1:29 PM, Warner Losh wrote: > >> On May 3, 2016, at 1:44 PM, Conrad Meyer wrote: >> >> On Tue, May 3, 2016 at 12:00 PM, Oliver Pinter >> wrote: >>> strlcpy instead or adjust the p->vendors size? >> >> Neither. The buffer is intentionally not nul-terminated. The >> coverity reports are false positives. > > Then wouldn=E2=80=99t memcmp be better? No, memcmp doesn't do anything like strncpy. memcpy wouldn't hurt but I don't see any reason to change it. Conrad