From owner-freebsd-java@FreeBSD.ORG Wed Jul 19 16:16:49 2006 Return-Path: X-Original-To: freebsd-java@freebsd.org Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4623E16A4DD for ; Wed, 19 Jul 2006 16:16:49 +0000 (UTC) (envelope-from lists@intricatesoftware.com) Received: from mta1.srv.hcvlny.cv.net (mta1.srv.hcvlny.cv.net [167.206.4.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id C577143D49 for ; Wed, 19 Jul 2006 16:16:48 +0000 (GMT) (envelope-from lists@intricatesoftware.com) Received: from [172.16.1.72] (ool-457a77e8.dyn.optonline.net [69.122.119.232]) by mta1.srv.hcvlny.cv.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTP id <0J2N00H4BRX3UQU0@mta1.srv.hcvlny.cv.net> for freebsd-java@freebsd.org; Wed, 19 Jul 2006 12:17:28 -0400 (EDT) Date: Wed, 19 Jul 2006 12:16:46 -0400 From: Kurt Miller In-reply-to: <200607182159.38840.kurt@intricatesoftware.com> To: freebsd-java@freebsd.org Message-id: <200607191216.46845.lists@intricatesoftware.com> MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_YfMvShG5DeTu0nzdOpwIhQ)" References: <200607131456.604@centrum.cz> <200607152340.1335@centrum.cz> <200607182159.38840.kurt@intricatesoftware.com> User-Agent: KMail/1.9.3 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: Re: diablo 1.5 crash X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: kurt@intricatesoftware.com List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2006 16:16:49 -0000 --Boundary_(ID_YfMvShG5DeTu0nzdOpwIhQ) Content-type: text/plain; charset=iso-8859-6 Content-transfer-encoding: 7BIT Content-disposition: inline On Tuesday 18 July 2006 9:59 pm, Kurt Miller wrote: > On Saturday 15 July 2006 5:40 pm, Jan Zach wrote: > > I was experimenting a bit and found the problematic font - > > it is x11-fonts/freefonts package > > Thanks. I was able to reproduce the crash here. I don't > know much about fonts, but I've determined that the > Old Town font in that package contains an illegal > glyph name (50_pct_gray) according to this document: > > http://partners.adobe.com/public/developer/opentype/index_glyph2.html#4 > > Still the jvm shouldn't crash on it. A glyph name beginning with > underscore is valid, but also not handled with the current > jvm code. Perhaps someone who knows more about fonts could add > support for underscores. In the meantime, here's a patch for > java/jdk15/files to avoid the crash. Trying attachment again, also inline... ========== patch-j2se::font::t1.c ================== --- ../../j2se/src/share/native/sun/font/t2k/t1.c.orig Tue Oct 19 15:00:39 2004 +++ ../../j2se/src/share/native/sun/font/t2k/t1.c Tue Jul 18 21:42:18 2006 @@ -2035,9 +2035,10 @@ if ( firstChar >= 'A' && firstChar <= 'Z' ) lookupIndex = firstChar - 'A'; - else + else if ( firstChar >= 'a' && firstChar <= 'z' ) lookupIndex = firstChar - 'a' + 26; - + else /* underscore is also valid but not handled */ + return 0; startIndex = PSNAME_START_INDEX[ lookupIndex ]; endIndex = PSNAME_START_INDEX[ lookupIndex + 1 ]; --Boundary_(ID_YfMvShG5DeTu0nzdOpwIhQ)--