Date: Thu, 10 Aug 2023 18:06:56 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 269616] [NEW PORT] astro/osmium-tool: Command line tool for working with OpenStreetMap data based on the Osmium library Message-ID: <bug-269616-7788-pDgDZ7wQcl@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-269616-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-269616-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269616 Ian Wagner <ianthetechie@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #240228|0 |1 is obsolete| | Attachment #244012| |maintainer-approval+ Flags| | --- Comment #4 from Ian Wagner <ianthetechie@gmail.com> --- Created attachment 244012 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D244012&action= =3Dedit Suggested patch (update 2) Good call-outs, Robert. I looked into these and it looks like this is a fun= one given how the build scripts are set up. I'm not a CMake expert, so I may ha= ve missed something. Manpages appear to be build solely based on Pandoc's availability. See the unconditional include here: https://github.com/osmcode/osmium-tool/blob/da012595a448019a356a169284f2636= d2ae0b7c3/CMakeLists.txt#L275. In the CMakeLists for that directory, it looks like manpages are built if Pandoc is available and there is no option to change that behavior: https://github.com/osmcode/osmium-tool/blob/da012595a448019a356a169284f2636= d2ae0b7c3/man/CMakeLists.txt#L6. I think the simplest option would be to just add Pandoc to BUILD_DEPENDS unconditionally and scrap the MANPAGES option. Any objections to that appro= ach? LZ4 does have an option: https://github.com/osmcode/osmium-tool/blob/da012595a448019a356a169284f2636= d2ae0b7c3/CMakeLists.txt#L32C8-L32C16. I've amended the Makefile to pass this through. Point taken on it not costi= ng much to enable; I assume most systems would already have it anyways, so thi= s is enabled by default in the new patch. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-269616-7788-pDgDZ7wQcl>