From owner-svn-src-all@FreeBSD.ORG Tue Oct 28 15:35:56 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6E645755; Tue, 28 Oct 2014 15:35:56 +0000 (UTC) Received: from mail.egr.msu.edu (gribble.egr.msu.edu [35.9.37.169]) by mx1.freebsd.org (Postfix) with ESMTP id 074C6C4F; Tue, 28 Oct 2014 15:35:56 +0000 (UTC) Received: from gribble (localhost [127.0.0.1]) by mail.egr.msu.edu (Postfix) with ESMTP id EDB793E76F; Tue, 28 Oct 2014 11:35:54 -0400 (EDT) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mail.egr.msu.edu ([127.0.0.1]) by gribble (gribble.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b7UcRqqabQ3i; Tue, 28 Oct 2014 11:35:54 -0400 (EDT) Received: from EGR authenticated sender Message-ID: <544FB7DA.8010502@egr.msu.edu> Date: Tue, 28 Oct 2014 11:35:54 -0400 From: Adam McDougall User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "bapt@FreeBSD.org >> Baptiste Daroussin" Subject: Re: svn commit: r273782 - in head/usr.sbin/pw: . tests References: <201410281454.s9SEs5kb098825@svn.freebsd.org> In-Reply-To: <201410281454.s9SEs5kb098825@svn.freebsd.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 15:35:56 -0000 On 10/28/2014 10:54, Baptiste Daroussin wrote: > Author: bapt > Date: Tue Oct 28 14:54:04 2014 > New Revision: 273782 > URL: https://svnweb.freebsd.org/changeset/base/273782 > > Log: > Do not delete the group wheel when bad argument is passed to pw groupdel -g > > Check that the -g argument is actually a number, if not report an error. > This argument is converted without checking with atoi(3) later so without this > check it converts any alpha entries into 0 meaning it deletes the group wheel > > Add a regression test about it > > PR: 90114 > Reported by: bkoenig@cs.tu-berlin.de > MFC after: 1 week > > Modified: > head/usr.sbin/pw/pw_group.c > head/usr.sbin/pw/tests/pw_delete.sh Would you mind looking at this related pw bug with patch? Thanks. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=187189