From owner-svn-src-all@FreeBSD.ORG Wed Dec 30 06:22:37 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DFE69106566C; Wed, 30 Dec 2009 06:22:37 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id 80D848FC0C; Wed, 30 Dec 2009 06:22:37 +0000 (UTC) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 63CCC1CD23; Wed, 30 Dec 2009 07:22:36 +0100 (CET) Date: Wed, 30 Dec 2009 07:22:36 +0100 From: Ed Schouten To: Gabor Kovesdan Message-ID: <20091230062236.GI64905@hoeg.nl> References: <200912292253.nBTMrR5m038869@svn.freebsd.org> <4B3AA7DC.1040606@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BIjZOsiIjIIrFhuO" Content-Disposition: inline In-Reply-To: <4B3AA7DC.1040606@FreeBSD.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r201227 - in head: sbin/comcontrol sbin/mount sbin/mount_msdosfs sbin/mount_nullfs sbin/rcorder usr.bin/find usr.bin/gencat usr.bin/mklocale usr.sbin/config usr.sbin/cpucontrol usr.sbin... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2009 06:22:38 -0000 --BIjZOsiIjIIrFhuO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Gabor, * Gabor Kovesdan wrote: > I wonder if it would be worth to invent a WARNS=3D7 level, which would > be WARNS=3D6 + ANSI. Although ANSI-conformance isn't a -Wfoo flag, > which is WARNS for but conforming ANSI means a higher level > cleannes, which is demanded, so I think it wouldn't really > contradict to the semantics of WARNS. So far I've been using -Wold-style-definition, which I've been using make these changes. I am planning on just adding that to WARNS=3D6, considering that almost all the code at WARNS=3D6 builds with this flag enabled now. I'd rather not add a WARNS=3D7, because then I'm afraid almost nobody will know about its existence, causing it to be mostly ignored. In an ideal world, I think we should get rid of WARNS. We could just enable all -W flags by default, except -Werror. That way people would be invited to fix the warnings over time. --=20 Ed Schouten WWW: http://80386.nl/ --BIjZOsiIjIIrFhuO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEUEARECAAYFAks68asACgkQ52SDGA2eCwUY1gCfZ1+AHZn2eYCBTzCEHp2TnfM+ /r8Al2c55mx66BqOWIMXr1og2m+koHs= =J67I -----END PGP SIGNATURE----- --BIjZOsiIjIIrFhuO--