From owner-freebsd-audit Sun Jun 9 18:33:24 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 61BB437B405 for ; Sun, 9 Jun 2002 18:33:19 -0700 (PDT) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.12.1/8.12.1) with ESMTP id g5A1X2x7096016; Sun, 9 Jun 2002 21:33:02 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: References: Date: Sun, 9 Jun 2002 21:33:01 -0400 To: freebsd-audit@FreeBSD.ORG From: Garance A Drosihn Subject: Re: Rewrite of much of lpc/cmds.c ... Cc: freebsd-print@bostonradio.org Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 5:52 PM -0400 6/8/02, Garance A Drosihn wrote: >I figure I better stop at this point, before I rewrite the >entire thing. Here is an update which basically rewrites > > abort disable enable restart > start stop up >I would like to commit this to current around June 15th. Actually, since this update will leave the previous versions of all the commands available, I'll probably commit it to current by Wednesday the 12th. I do have additional updates to lpc/cmds.c which will be available by the weekend. (they're already written, actually, but I'm still checking them over). >Here is the update: >Index: lpc/cmds.c >=================================================================== > /* >+ * kill an existing daemon and disable printing. >+ */ >+void >+abort_q(struct printer *pp) >+{ I am still making a few cosmetic changes to this update (such as rewording some comments), and in the process I did notice that the abort_q routine needs a: if (setres >= 0) { seteuid(euid); upstat(pp, "printing disabled\n"); seteuid(uid); } at the end of the routine, to completely reproduce the behavior of the previous implementation of abortpr. So, I've added it... -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message