From owner-svn-src-head@freebsd.org  Wed May 25 15:52:39 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDDA4B4943A;
 Wed, 25 May 2016 15:52:39 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id B793C1A2B;
 Wed, 25 May 2016 15:52:39 +0000 (UTC)
 (envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
 by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u4PFqV5X006311;
 Wed, 25 May 2016 08:52:35 -0700 (PDT)
 (envelope-from truckman@FreeBSD.org)
Message-Id: <201605251552.u4PFqV5X006311@gw.catspoiler.org>
Date: Wed, 25 May 2016 08:52:31 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
Subject: Re: svn commit: r300686 - head/sbin/camcontrol
To: src-committers@freebsd.org
cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org
In-Reply-To: <201605251549.u4PFnTkp079365@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2016 15:52:40 -0000

On 25 May, To: src-committers@freebsd.org wrote:
> Author: truckman
> Date: Wed May 25 15:49:29 2016
> New Revision: 300686
> URL: https://svnweb.freebsd.org/changeset/base/300686
> 
> Log:
>   Fix a couple of Coverity Unintended sign extension sign extension
>   defects.  When shifting an unsigned byte into the upper 8 bits of
>   an int and the resulting value is greater than 0x7FFFFFF, the result
>   will be sign extended when converting to a 64 bit unsigned long.
>   Fix by casting to (uint64_t) before the shift.
>   
>   Reported by:	Coverity
>   CID:		1356044, 1356045
>   Reviewed by:	ken

Differential Revision:	https://reviews.freebsd.org/D6557