From nobody Thu Feb 23 02:59:57 2023
X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PMd6r3lssz3sqv0;
	Thu, 23 Feb 2023 03:00:04 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Received: from glebi.us (glebi.us [162.251.186.162])
	by mx1.freebsd.org (Postfix) with ESMTP id 4PMd6r1VCNz4J31;
	Thu, 23 Feb 2023 03:00:04 +0000 (UTC)
	(envelope-from glebius@freebsd.org)
Authentication-Results: mx1.freebsd.org;
	none
Received: by glebi.us (Postfix, from userid 1000)
	id B6FF23A868; Wed, 22 Feb 2023 18:59:57 -0800 (PST)
Date: Wed, 22 Feb 2023 18:59:57 -0800
From: Gleb Smirnoff <glebius@freebsd.org>
To: Michael Tuexen <tuexen@freebsd.org>
Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org,
	dev-commits-src-main@freebsd.org
Subject: Re: git: 453aa7fac989 - main - tcp: ensure the tcpcb is not NULL
 when logging an event
Message-ID: <Y/bWrQbl6AC6xdYW@FreeBSD.org>
References: <202302230104.31N14Z9h029777@gitrepo.freebsd.org>
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-all@freebsd.org
X-BeenThere: dev-commits-src-all@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202302230104.31N14Z9h029777@gitrepo.freebsd.org>
X-Rspamd-Queue-Id: 4PMd6r1VCNz4J31
X-Spamd-Bar: ----
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-ThisMailContainsUnwantedMimeParts: N

On Thu, Feb 23, 2023 at 01:04:35AM +0000, Michael Tuexen wrote:
M> The branch main has been updated by tuexen:
M> 
M> URL: https://cgit.FreeBSD.org/src/commit/?id=453aa7fac9894945282bcf6ef55c9ebaaa1d7e40
M> 
M> commit 453aa7fac9894945282bcf6ef55c9ebaaa1d7e40
M> Author:     Michael Tuexen <tuexen@FreeBSD.org>
M> AuthorDate: 2023-02-23 01:01:53 +0000
M> Commit:     Michael Tuexen <tuexen@FreeBSD.org>
M> CommitDate: 2023-02-23 01:04:17 +0000
M> 
M>     tcp: ensure the tcpcb is not NULL when logging an event
M>     
M>     When calling tcp_bblog_pru() on some error paths, tp is NULL,
M>     therefore handle it.

I wonder when does that happen? IMHO better fix such calls than
plug the problem here.

-- 
Gleb Smirnoff