Date: Fri, 12 Jul 2013 22:36:26 +0000 (UTC) From: Jack F Vogel <jfv@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r253303 - in head/sys: dev/e1000 modules/em modules/igb Message-ID: <201307122236.r6CMaQq4075062@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jfv Date: Fri Jul 12 22:36:26 2013 New Revision: 253303 URL: http://svnweb.freebsd.org/changeset/base/253303 Log: Change the E1000 driver option header handling to match the ixgbe driver. As it was, when building them as a module INET and INET6 are not defined. In these drivers it does not cause a panic, however it does result in different behavior in the ioctl routine when you are using a module vs static, and I think the behavior should be the same. MFC after: 3 days Modified: head/sys/dev/e1000/if_em.c head/sys/dev/e1000/if_igb.c head/sys/dev/e1000/if_lem.c head/sys/modules/em/Makefile head/sys/modules/igb/Makefile Modified: head/sys/dev/e1000/if_em.c ============================================================================== --- head/sys/dev/e1000/if_em.c Fri Jul 12 22:16:43 2013 (r253302) +++ head/sys/dev/e1000/if_em.c Fri Jul 12 22:36:26 2013 (r253303) @@ -32,10 +32,11 @@ ******************************************************************************/ /*$FreeBSD$*/ -#ifdef HAVE_KERNEL_OPTION_HEADERS -#include "opt_device_polling.h" #include "opt_inet.h" #include "opt_inet6.h" + +#ifdef HAVE_KERNEL_OPTION_HEADERS +#include "opt_device_polling.h" #endif #include <sys/param.h> Modified: head/sys/dev/e1000/if_igb.c ============================================================================== --- head/sys/dev/e1000/if_igb.c Fri Jul 12 22:16:43 2013 (r253302) +++ head/sys/dev/e1000/if_igb.c Fri Jul 12 22:36:26 2013 (r253303) @@ -33,10 +33,11 @@ /*$FreeBSD$*/ -#ifdef HAVE_KERNEL_OPTION_HEADERS -#include "opt_device_polling.h" #include "opt_inet.h" #include "opt_inet6.h" + +#ifdef HAVE_KERNEL_OPTION_HEADERS +#include "opt_device_polling.h" #include "opt_altq.h" #endif Modified: head/sys/dev/e1000/if_lem.c ============================================================================== --- head/sys/dev/e1000/if_lem.c Fri Jul 12 22:16:43 2013 (r253302) +++ head/sys/dev/e1000/if_lem.c Fri Jul 12 22:36:26 2013 (r253303) @@ -32,10 +32,11 @@ ******************************************************************************/ /*$FreeBSD$*/ -#ifdef HAVE_KERNEL_OPTION_HEADERS -#include "opt_device_polling.h" #include "opt_inet.h" #include "opt_inet6.h" + +#ifdef HAVE_KERNEL_OPTION_HEADERS +#include "opt_device_polling.h" #endif #include <sys/param.h> Modified: head/sys/modules/em/Makefile ============================================================================== --- head/sys/modules/em/Makefile Fri Jul 12 22:16:43 2013 (r253302) +++ head/sys/modules/em/Makefile Fri Jul 12 22:36:26 2013 (r253303) @@ -1,7 +1,10 @@ # $FreeBSD$ + +.include <bsd.own.mk> + .PATH: ${.CURDIR}/../../dev/e1000 KMOD = if_em -SRCS = device_if.h bus_if.h pci_if.h opt_inet.h +SRCS = device_if.h bus_if.h pci_if.h opt_inet.h opt_inet6.h SRCS += $(CORE_SRC) $(LEGACY_SRC) SRCS += $(COMMON_SHARED) $(LEGACY_SHARED) $(PCIE_SHARED) CORE_SRC = if_em.c e1000_osdep.c @@ -18,4 +21,16 @@ CFLAGS += -I${.CURDIR}/../../dev/e1000 # DEVICE_POLLING for a non-interrupt-driven method #CFLAGS += -DDEVICE_POLLING +.if !defined(KERNBUILDDIR) +.if ${MK_INET_SUPPORT} != "no" +opt_inet.h: + @echo "#define INET 1" > ${.TARGET} +.endif + +.if ${MK_INET6_SUPPORT} != "no" +opt_inet6.h: + @echo "#define INET6 1" > ${.TARGET} +.endif +.endif + .include <bsd.kmod.mk> Modified: head/sys/modules/igb/Makefile ============================================================================== --- head/sys/modules/igb/Makefile Fri Jul 12 22:16:43 2013 (r253302) +++ head/sys/modules/igb/Makefile Fri Jul 12 22:36:26 2013 (r253303) @@ -1,7 +1,10 @@ #$FreeBSD$ + +.include <bsd.own.mk> + .PATH: ${.CURDIR}/../../dev/e1000 KMOD = if_igb -SRCS = device_if.h bus_if.h pci_if.h opt_inet.h +SRCS = device_if.h bus_if.h pci_if.h opt_inet.h opt_inet6.h SRCS += if_igb.c $(SHARED_SRCS) SHARED_SRCS = e1000_api.c e1000_phy.c e1000_nvm.c e1000_mac.c e1000_manage.c SHARED_SRCS += e1000_80003es2lan.c e1000_82542.c e1000_82541.c e1000_82543.c @@ -20,4 +23,16 @@ CFLAGS += -I${.CURDIR}/../../dev/e1000 - # ALTQ. #CFLAGS += -DIGB_LEGACY_TX +.if !defined(KERNBUILDDIR) +.if ${MK_INET_SUPPORT} != "no" +opt_inet.h: + @echo "#define INET 1" > ${.TARGET} +.endif + +.if ${MK_INET6_SUPPORT} != "no" +opt_inet6.h: + @echo "#define INET6 1" > ${.TARGET} +.endif +.endif + .include <bsd.kmod.mk>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307122236.r6CMaQq4075062>