From owner-cvs-all@FreeBSD.ORG Tue Aug 30 09:51:55 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9FD7B16A41F; Tue, 30 Aug 2005 09:51:55 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 731A043D48; Tue, 30 Aug 2005 09:51:55 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j7U9ptDg056484; Tue, 30 Aug 2005 09:51:55 GMT (envelope-from glebius@repoman.freebsd.org) Received: (from glebius@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j7U9pt9d056483; Tue, 30 Aug 2005 09:51:55 GMT (envelope-from glebius) Message-Id: <200508300951.j7U9pt9d056483@repoman.freebsd.org> From: Gleb Smirnoff Date: Tue, 30 Aug 2005 09:51:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netgraph ng_pptpgre.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2005 09:51:55 -0000 glebius 2005-08-30 09:51:54 UTC FreeBSD src repository Modified files: sys/netgraph ng_pptpgre.c Log: Lock down PPTP node, since it has many data structures, that won't survive parallel ng_pptp_rcvdata(): - Add a per-node mutex. - Acquire mutex during all ng_pptp_rcvdata() method. - Make callouts protected by mutex. Now callouts count as netgraph writers, but there are plans to allow reader callouts for nodes, that have internal locking. - Acquire mutex in ng_pptp_reset(), which can be triggered by a message or node shutdown. PR: kern/80035 Tested by: Deomid Ryabkov Reviewed by: Deomid Ryabkov Revision Changes Path 1.38 +25 -7 src/sys/netgraph/ng_pptpgre.c