From owner-freebsd-perl@FreeBSD.ORG Fri Apr 6 16:49:12 2012 Return-Path: Delivered-To: perl@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 205811065672; Fri, 6 Apr 2012 16:49:12 +0000 (UTC) (envelope-from mel@datakitty.lan.rachie.is-a-geek.net) Received: from datakitty.lan.rachie.is-a-geek.net (rachie.is-a-geek.net [66.230.99.27]) by mx1.freebsd.org (Postfix) with ESMTP id 2B2EB8FC0A; Fri, 6 Apr 2012 16:49:08 +0000 (UTC) Received: from datakitty.lan.rachie.is-a-geek.net (localhost [127.0.0.1]) by datakitty.lan.rachie.is-a-geek.net (8.14.5/8.14.5) with ESMTP id q36Gn6j6085093; Fri, 6 Apr 2012 08:49:06 -0800 (AKDT) (envelope-from mel@datakitty.lan.rachie.is-a-geek.net) Received: (from mel@localhost) by datakitty.lan.rachie.is-a-geek.net (8.14.5/8.14.5/Submit) id q36Gn6Li085092; Fri, 6 Apr 2012 08:49:06 -0800 (AKDT) (envelope-from mel) Date: Fri, 6 Apr 2012 08:49:06 -0800 (AKDT) Message-Id: <201204061649.q36Gn6Li085092@datakitty.lan.rachie.is-a-geek.net> To: FreeBSD-gnats-submit@freebsd.org From: Mel Flynn X-send-pr-version: 3.113 X-GNATS-Notify: Cc: Steve Wills , Mantainer Subject: [patch] net/p5-Net-Radius: Fix test breakage X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Mel Flynn List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2012 16:49:12 -0000 >Submitter-Id: current-users >Originator: Mel Flynn >Organization: >Confidential: no >Synopsis: [patch] net/p5-Net-Radius: Fix test breakage >Severity: non-critical >Priority: low >Category: ports >Class: sw-bug >Release: FreeBSD 8.2-STABLE amd64 >Environment: System: FreeBSD datakitty.lan.rachie.is-a-geek.net 8.2-STABLE FreeBSD 8.2-STABLE #6 r230977: Sun Feb 5 06:20:11 AKST 2012 mel@datakitty.lan.rachie.is-a-geek.net:/data/obj/data/RELENG_8/src/sys/GENERIC amd64 >Description: The post-extract target deletes carriage returns from all files in the distribution. There's only one file containing a carriage return and this isn't the usual case of "windows line endings", but is part of a binary packet. Removing these carriage returns breaks t/packet.t for that packet test. >How-To-Repeat: cd /usr/ports/net/p5-Net-Radius make build cd `make -V WRKSRC` make test >Fix: While in here, add TEST_DEPENDS. --- net__p5-Net-Radius.patch begins here --- Removing \r in packets/huawei-me60-accreq-01.p will make the tests fail. diff -urN --exclude CVS --exclude '*~' net/p5-Net-Radius/Makefile /usr/ports/net/p5-Net-Radius/Makefile --- net/p5-Net-Radius/Makefile.orig 2009-12-14 21:26:23.000000000 -0900 +++ net/p5-Net-Radius/Makefile 2012-04-06 07:56:26.000000000 -0800 @@ -14,10 +14,10 @@ MAINTAINER= perl@FreeBSD.org COMMENT= A perl module to manipulate RADIUS packets +TEST_DEPENDS= p5-Test-Warn>=0:${PORTSDIR}/devel/p5-Test-Warn \ + p5-Test-Pod>=0:${PORTSDIR}/devel/p5-Test-Pod + PERL_CONFIGURE= yes MAN3= Net::Radius::Dictionary.3 Net::Radius::Packet.3 -post-extract: - ${FIND} ${WRKDIR} -type f | ${XARGS} ${PERL5} -pi -e "s:\r::g" - .include --- net__p5-Net-Radius.patch ends here ---