From nobody Wed Apr 22 16:30:00 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g14St0Cv7z6ZsHd for ; Wed, 22 Apr 2026 16:30:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g14Ss6Tpfz3wTv for ; Wed, 22 Apr 2026 16:30:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776875405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Kzo4nVADy+h+s9RM95hJY9t7Sv8a9gFWdnI5+hAcaic=; b=Ow8/psldI+nWo0k4dfDNX+1vnqkOnESIUh+rRO/FOK+lhLB+sSIh18xpRSGoLuD14mJ9xt B2fRolkOgQ2l4/8mCElG1woZL/MBqFpRiCzDeG+C0XEBzr2AW4E6sWZ768XY5doqV/DOFG P3cWMBmgMGVx6rBVs2z8bpFfhNFCaGsXkh0R37VZorD5XXcayZvB0Uug8VO6N9HbeTVrw0 Y2iWLTn6wptxx8JHrHz+GVclsycETHbPYKQAEkUPzkPQ7X0EiSZcSO0fYeaO1W2qe0CjwM BWBzsEmBnILkZ1X5qvNLtxfwMtguQdCSjRAnzr5dSZtvF5Ng/0MiW7L+xLordQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776875405; a=rsa-sha256; cv=none; b=FLMOHlhBWeP2SnHuus1UxBPEBmuuz6u+zJecVxiGdvKP98X69LPWN+uzPleGueJRSo5Pyi 3ekMb9AA2lO6NUWhruntkqH+w5+5kWzxvqlTHmSZQG4qEkUO29k8Reysa/7SBLb3zb0oEm v8kNB9vBRsFM3H51zB8PoxxWECD0+etePVy+CNhVPZpqVz6niixiB8Dfjshu6gEWfb20qQ Ndbb0DNgtAO4zWuVcybQBEr8xqmGTgykNjIH2Y4/R0INQMbPhWIFAmn+SutwfbSsBBWel1 MizgpkIOALm6SI4uybjxk+H01dBqHTs7o83tniAVTUPSkRbfLff1Nh3kVLTASg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776875405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Kzo4nVADy+h+s9RM95hJY9t7Sv8a9gFWdnI5+hAcaic=; b=YrL8Gtf9ho5FODjtkCFKPKWyOvwWC5jp+xqJua7cgqjh6XAMjdxqdFw78bxyFLE6fqOhT/ Rz+w5B3g8/kfuqgWaiAxIMm5zZah2n91G6NA1qDAHt9hSEXq3XX7lr7WACKbyBNiiZYNlY chQZkSP99m2fyI61D7UIwIT79CyyJS0WB959MO2uydqiPD7SKmM169jFjMgUCBXg73wXSS S1Ec3MqtPnf3PwBv3Mj+q/sHCAWi36qyjuxZJZwwku9wnUX5FhQoGN828Wvuf/4JCf1mZK ZLEooLjrh2bedomqSGcMtXdSCLS0Zmsnk918so9cObG0oqFKmp4fgH0qNjv2LQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g14Ss61BjzfFF for ; Wed, 22 Apr 2026 16:30:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3b784 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 22 Apr 2026 16:30:00 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Justin Hibbits Subject: git: e3e8ec2ab620 - main - kexec: Disallow kexec_load if securelevel > 0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhibbits X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e3e8ec2ab620f026b42b4988fce49eff7cec16eb Auto-Submitted: auto-generated Date: Wed, 22 Apr 2026 16:30:00 +0000 Message-Id: <69e8f788.3b784.63433929@gitrepo.freebsd.org> The branch main has been updated by jhibbits: URL: https://cgit.FreeBSD.org/src/commit/?id=e3e8ec2ab620f026b42b4988fce49eff7cec16eb commit e3e8ec2ab620f026b42b4988fce49eff7cec16eb Author: Justin Hibbits AuthorDate: 2026-04-22 15:51:06 +0000 Commit: Justin Hibbits CommitDate: 2026-04-22 16:28:54 +0000 kexec: Disallow kexec_load if securelevel > 0 kexec_load() + reboot is intended to be equivalent to a system reboot. However kexec_load() can load arbitrary data as the target kernel, leading to execution of arbitrary code, even though it's effectively in a new context. Rather than being equivalent to a system reboot, it's also equivalent to kldload(), which loads arbitrary code into the running kernel. Since kldload() is blocked at securelevel 1, also block kexec_load(). Reported by: markj Fixes: e02c57ff3 ("kern: Introduce kexec system feature (MI)") Sponsored by: Hewlett Packard Enterprise Differential Revision: https://reviews.freebsd.org/D56580 --- sys/kern/kern_kexec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/kern/kern_kexec.c b/sys/kern/kern_kexec.c index 86ee9da9a606..5ba76512e963 100644 --- a/sys/kern/kern_kexec.c +++ b/sys/kern/kern_kexec.c @@ -342,6 +342,9 @@ sys_kexec_load(struct thread *td, struct kexec_load_args *uap) { int error; + error = securelevel_gt(td->td_ucred, 0); + if (error != 0) + return (error); // FIXME: Do w need a better privilege check than PRIV_REBOOT here? error = priv_check(td, PRIV_REBOOT); if (error != 0)