From owner-svn-src-all@FreeBSD.ORG Sat Nov 29 14:26:22 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 675721065670; Sat, 29 Nov 2008 14:26:22 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 617A98FC08; Sat, 29 Nov 2008 14:26:22 +0000 (UTC) (envelope-from rpaulo@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id mATEQMKE053592; Sat, 29 Nov 2008 14:26:22 GMT (envelope-from rpaulo@svn.freebsd.org) Received: (from rpaulo@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id mATEQMN2053591; Sat, 29 Nov 2008 14:26:22 GMT (envelope-from rpaulo@svn.freebsd.org) Message-Id: <200811291426.mATEQMN2053591@svn.freebsd.org> From: Rui Paulo Date: Sat, 29 Nov 2008 14:26:22 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r185434 - head/sys/dev/k8temp X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Nov 2008 14:26:22 -0000 Author: rpaulo Date: Sat Nov 29 14:26:22 2008 New Revision: 185434 URL: http://svn.freebsd.org/changeset/base/185434 Log: Check the return value of config_intrhook_establish(). Found with: Coverity Prevent(tm) CID: 2115 Modified: head/sys/dev/k8temp/k8temp.c Modified: head/sys/dev/k8temp/k8temp.c ============================================================================== --- head/sys/dev/k8temp/k8temp.c Sat Nov 29 14:20:36 2008 (r185433) +++ head/sys/dev/k8temp/k8temp.c Sat Nov 29 14:26:22 2008 (r185434) @@ -187,7 +187,11 @@ k8temp_attach(device_t dev) */ sc->sc_ich.ich_func = k8temp_intrhook; sc->sc_ich.ich_arg = dev; - config_intrhook_establish(&sc->sc_ich); + if (config_intrhook_establish(&sc->sc_ich) != 0) { + device_printf(dev, "config_intrhook_establish " + "failed!\n"); + return (ENXIO); + } /* * dev.k8temp.N tree.