From owner-svn-ports-all@freebsd.org Tue Dec 19 13:12:05 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4AD83E81D1B; Tue, 19 Dec 2017 13:12:05 +0000 (UTC) (envelope-from rodrigo@FreeBSD.org) Received: from smtp.osorio.me (smtp.osorio.me [5.196.94.126]) by mx1.freebsd.org (Postfix) with ESMTP id 1443377DF9; Tue, 19 Dec 2017 13:12:04 +0000 (UTC) (envelope-from rodrigo@FreeBSD.org) Received: from [172.16.33.187] (unknown [213.174.108.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.osorio.me (Postfix) with ESMTPSA id D63C331163; Tue, 19 Dec 2017 13:12:01 +0000 (UTC) Subject: Re: svn commit: r456527 - in head/databases: . postgis20 postgis21 postgis22 postgis23 postgis24 To: Mathieu Arnold , Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201712171125.vBHBPEGU053728@repo.freebsd.org> <20171217114147.GA19802@FreeBSD.org> <20171218010012.GA76552@FreeBSD.org> <49742f49-87aa-9f6e-21ff-20ad5d1598cd@FreeBSD.org> From: Rodrigo Osorio Message-ID: <3d5be087-2880-75c6-dd2c-c05e4569aab3@FreeBSD.org> Date: Tue, 19 Dec 2017 14:11:59 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 13:12:05 -0000 On 12/19/17 13:38, Mathieu Arnold wrote: > Le 18/12/2017 à 15:07, Mathieu Arnold a écrit : >> Le 18/12/2017 à 10:15, Rodrigo Osorio a écrit : >>> On 12/18/17 02:00, Alexey Dokuchaev wrote: >>>> On Sun, Dec 17, 2017 at 01:25:43PM +0100, Rodrigo Osorio wrote: >>>>> On 12/17/17 12:41, Alexey Dokuchaev wrote: >>>>>> On Sun, Dec 17, 2017 at 11:25:14AM +0000, Rodrigo Osorio wrote: >>>>>>> New Revision: 456527 >>>>>>> URL: https://svnweb.freebsd.org/changeset/ports/456527 >>>>>>> >>>>>>> Log: >>>>>>>     Add new port postgis24 for v2.4.x >>>>>>> >>>>>>> Added: >>>>>>>     head/databases/postgis24/ >>>>>>>     head/databases/postgis24/Makefile   (contents, props changed) >>>>>>>     head/databases/postgis24/distinfo   (contents, props changed) >>>>>>>     head/databases/postgis24/pkg-descr   (contents, props changed) >>>>>>>     head/databases/postgis24/pkg-install   (contents, props changed) >>>>>>>     head/databases/postgis24/pkg-plist   (contents, props changed) >>>>>> Looks like it should've been repocopied, not added as a new port. >>>>>> Can you explain why this wasn't done? >>>>> I don't get your question, do you see any issue regarding postgis24 >>>>> port? >>>> I have an issue not with the port per se, but with the way it was >>>> carried >>>> out (added to the collection).  Please read Section 19.4* of the Ports >>>> Committer's Guide, albeit I'm surprised that your mentor did not tell >>>> you >>>> about it earlier. >>> Now I understand... >>> >>> To clarify my mentor instruct me about the procedure but it was a long >>> time ago. >>> I don't do this kind of commit so often, and this is probably my mistake. >> Now that this is all clarified and you know what to do, please remove >> the postgis24 port you added, and add it back using the proper procedure. > > Ping ? > > Mathieu, To be sure to do it once I submit the final fix as a review yesterday : https://reviews.freebsd.org/D13533. I notify danfe about it but has no feedback so I will commit the changes regards - rodrigo