From owner-freebsd-ports  Fri Jan 11 10:28:29 2002
Delivered-To: freebsd-ports@freebsd.org
Received: from wwweasel.geeksrus.net (wwweasel.geeksrus.net [64.67.200.82])
	by hub.freebsd.org (Postfix) with ESMTP
	id A65AF37B423; Fri, 11 Jan 2002 10:27:52 -0800 (PST)
Received: (from alane@localhost)
	by wwweasel.geeksrus.net (8.11.6/8.11.6) id g0BIRLw43300;
	Fri, 11 Jan 2002 13:27:21 -0500 (EST)
	(envelope-from alane)
Date: Fri, 11 Jan 2002 13:27:21 -0500
From: Alan Eldridge <alane@geeksrus.net>
To: dwcjr@freebsd.org
Cc: FreeBSD Ports List <ports@freebsd.org>
Subject: CUPS support can be unconditional
Message-ID: <20020111182721.GA42417@wwweasel.geeksrus.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.24i
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

I would recommend, upon some reflection, doing this the way we did in
kdelibs.  That is, cups-base is unconditional. If somebody really
wants to use cups, they can't rely on another port to suck it in via
dependency anyway; it doesn't work without being configured.

If they don't want to use cups, fine. The libraries don't hurt anything.
That's why cups was broken into two ports. Nothing should depend on the
cups meta-port.

Index: samba/Makefile
===================================================================
RCS file: /home/alane/cvsroot/ports/net/samba/Makefile,v
retrieving revision 1.67
diff -u -3 -r1.67 Makefile
--- samba/Makefile	11 Jan 2002 03:46:05 -0000	1.67
+++ samba/Makefile	11 Jan 2002 18:07:26 -0000
@@ -18,9 +18,7 @@
 
 MAINTAINER=	dwcjr@FreeBSD.org
 
-.if defined(WITH_CUPS)
 LIB_DEPENDS=	cups.2:${PORTSDIR}/print/cups-base
-.endif
 
 .if defined(WITH_RECYCLE)
 PATCH_SITES+=	http://www.amherst.edu/~bbstone/recycle_bin/2.2.2/
@@ -50,10 +48,8 @@
 CONFIGURE_ARGS+=	--with-krb5=${KRB5_HOME}
 .endif
 
-.if defined(WITH_CUPS)
 # This enables CUPS printing support in Samba.
 CONFIGURE_ARGS+=	--with-cups=${LOCALBASE}
-.endif
 
 .if defined(WITH_ACL_SUPPORT)
 .if ${OSVERSION} < 500018
Index: samba-devel/Makefile
===================================================================
RCS file: /home/alane/cvsroot/ports/net/samba-devel/Makefile,v
retrieving revision 1.77
diff -u -3 -r1.77 Makefile
--- samba-devel/Makefile	11 Jan 2002 03:45:12 -0000	1.77
+++ samba-devel/Makefile	11 Jan 2002 18:07:03 -0000
@@ -18,9 +18,7 @@
 
 MAINTAINER=	dwcjr@FreeBSD.org
 
-.if defined(WITH_CUPS)
 LIB_DEPENDS=	cups.2:${PORTSDIR}/print/cups-base
-.endif
 
 # directories
 VARDIR=		/var
@@ -49,10 +47,8 @@
 CONFIGURE_ARGS+=	--with-krb5=no
 .endif
 
-.if defined(WITH_CUPS)
 # This enables CUPS printing support in Samba.
 CONFIGURE_ARGS+=	--with-cups=${LOCALBASE}
-.endif
 
 .if defined(WITH_ACL_SUPPORT)
 .if ${OSVERSION} < 500018

-- 
Alan Eldridge
Pmmfmffmmfmp mmmpppppffmpmfpmpppff PmpMpmMpp ppfppp MpfpffmppmppMmpFmmMpm 
mfpmmmmmfpmpmpppff.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message