From owner-freebsd-current@freebsd.org Mon May 21 18:40:52 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 777FBEFBD8C for ; Mon, 21 May 2018 18:40:52 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-yb0-x241.google.com (mail-yb0-x241.google.com [IPv6:2607:f8b0:4002:c09::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0A3396B5C8 for ; Mon, 21 May 2018 18:40:52 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-yb0-x241.google.com with SMTP id o80-v6so5418540ybc.7 for ; Mon, 21 May 2018 11:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AqRTCduI3tY+BUD7f0M3xRzYIk9La4KdB4ohmtbi2Sg=; b=UiHCZlJcM5HsmEuHU9SAS0RBOPuoxoaDLZdIgWj2OdifEDKewSttIgji3odrKGaeZV Ct0sbNESGyGW+yE+ZtJjHDxzTC0Tzs5teB/dHZnWNVVD8MKdJHY+dN9v0dg9rUq3R9Aa EnAUdRrfumJiMsNK5t8TIAtnrSzMtAUiKKRfpwT3bxTdMXN8dySjvNpHEm6mQCEpV0Gw fYJGHKCUszG1lwfOR2rX+YqbtMQMjgZvdgof3W3sWGdUXXHikIU6JScRIxqFpA7/LloH sy3YO6YLPbraA4mgar92FX9hBy42XW0fbV0M23ECmHW6sMERwaLymIgC58FGSo+xzbkF Hb1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AqRTCduI3tY+BUD7f0M3xRzYIk9La4KdB4ohmtbi2Sg=; b=CeJJIt4QNewv6D+IdtGkva480HcEsUGMld/a43u9Mme8Mfs36CNUXt8a0uvJPHUiEo SXPcfK5qb2Qm6fkS2Hl08QZV6Q5FFwwKv5E0BRUn+LqxXazYCpfVoAq+5MolC4kScr6l U9wfd5lVpTvyc+vN39Kdv7mi7kQj/c3nfO+WG2aEGq+kqIFM3rOpb7aRN0p1XZq1YXsH C7zwJ2/0SxB5ujZoRX3kdhJpkcAiLmCZTH4dJ6y9w50CmykkO9Xcxe/tck477zyqmtnQ BgeWMoMr19dq5+BD0AbTHQrgpZcRLpl6zFNizZR9msR0QRScs4/SHKAL2nIoVgHD3/0k MJMg== X-Gm-Message-State: ALKqPwc8zC5967w1uG+N2peNEtKO4P0pSdqWseM/01WCLGEvt3/HOehC +Xe3q3LHhanREa2E4UwcrzyZg/8VYRnsZjPPPc3fmw== X-Google-Smtp-Source: AB8JxZopEbS2qRdPQqDREH9h9fAZxQt5IxICCuCT4IU5kg9KgxJtyAFaP1DYg6sUhdaOEj2Vi2h0XT1GSCV8ucxV5LA= X-Received: by 2002:a25:2a8c:: with SMTP id q134-v6mr6479716ybq.29.1526928051307; Mon, 21 May 2018 11:40:51 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:3894:0:0:0:0:0 with HTTP; Mon, 21 May 2018 11:40:50 -0700 (PDT) In-Reply-To: References: <3a5edc5c-3caa-830b-4bd9-53ff52feb8a7@freebsd.org> <20180518193009.GA88432@troutmask.apl.washington.edu> <20180520164011.GA6276@troutmask.apl.washington.edu> <88843bfb-34de-382c-9409-83f9ad54c8c4@daemonic.se> <20180521024050.0857a787@gmail.com> <20180521170728.GA14025@troutmask.apl.washington.edu> <20180521181057.GA86707@troutmask.apl.washington.edu> From: Oliver Pinter Date: Mon, 21 May 2018 20:40:50 +0200 Message-ID: Subject: Re: [RFC] Deprecation and removal of the drm2 driver To: sgk@troutmask.apl.washington.edu Cc: Pete Wright , Rozhuk Ivan , Niclas Zeising , FreeBSD X11 mailing list , Current FreeBSD , Warner Losh Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 18:40:52 -0000 On 5/21/18, Oliver Pinter wrote: > On 5/21/18, Steve Kargl wrote: >> On Mon, May 21, 2018 at 10:29:54AM -0700, Pete Wright wrote: >>> >>> On 05/21/2018 10:07, Steve Kargl wrote: >>> > On Mon, May 21, 2018 at 02:40:50AM +0300, Rozhuk Ivan wrote: >>> >> On Sun, 20 May 2018 21:10:28 +0200 >>> >> Oliver Pinter wrote: >>> >> >>> >>>> One of the reasons for the deprecation and removal of the drm2 bits >>> >>>> is that they prevent us from automatically loading the >>> >>>> drm-next/stable-kmod kernel modules, since the two collide. >>> >>>> Regards >>> >>> >>> >>> Then it wold be better to resolve this problem, rather then removing >>> >>> a >>> >>> working solution. What's about module versioning what in other cases >>> >>> works? >>> >>> >>> >> May be just move old drm2 to ports? >>> > Why? "If it isn't broken, why fix it?" >>> > >>> > The conflict affects x86_64-*-freebsd aka amd64. The >>> > conflict does not affect any other architecture. The >>> > Makefile infrastructure can use MACHINE_ARCH to exclude >>> > drm2 from build of amd64. >>> > >>> > I don't use netgraph or any of the if_*.ko modules. >>> > Can we put all of that into ports? I don't use any >>> > scsi controllers, so those can go too. Why make it >>> > insanely fun for users to configure a FreeBSD system. >>> to play devils advocate - why include a kernel module that causes >>> conflicts for a vast majority of the laptop devices that you can >>> purchase today (as well as for the foreseeable future), while forcing >>> the up to date and actively developed driver to not work out of the box? >> >> Poor advocacy. I stated old drm2 can be excluded by the >> Makefile infrastructure and I've already provided a barebones >> patch. >> >> Index: sys/modules/Makefile >> =================================================================== >> --- sys/modules/Makefile (revision 333609) >> +++ sys/modules/Makefile (working copy) >> @@ -112,7 +112,9 @@ >> ${_dpms} \ >> ${_dpt} \ >> ${_drm} \ >> +.if ${MACHINE_ARCH} != amd64 >> ${_drm2} \ >> +.endif >> dummynet \ >> ${_ed} \ >> ${_efirt} \ > > I prefer something like this: > > op@opn src# git diff > diff --git a/sys/amd64/conf/GENERIC b/sys/amd64/conf/GENERIC > index 195b66daab51..034e2f8126fd 100644 > --- a/sys/amd64/conf/GENERIC > +++ b/sys/amd64/conf/GENERIC > @@ -23,6 +23,7 @@ ident GENERIC > > makeoptions DEBUG=-g # Build kernel with gdb(1) debug > symbols > makeoptions WITH_CTF=1 # Run ctfconvert(1) for DTrace > support > +makeoptions WITHOUT_MODULES="drm drm2" # by default disable the > building of DRM* for GENERIC > > options SCHED_ULE # ULE scheduler > options PREEMPTION # Enable kernel thread preemption > Or make the function in this file smarter: "./hw/xfree86/os-support/bsd/bsd_kmod.c" #ifdef HAVE_XORG_CONFIG_H #include #endif #include #include #include #include #include #include "xf86_OSproc.h" /* * Load a FreeBSD kernel module. * This is used by the DRI/DRM to load a DRM kernel module when * the X server starts. It could be used for other purposes in the future. * Input: * modName - name of the kernel module (Ex: "tdfx") * Return: * 0 for failure, 1 for success */ int xf86LoadKernelModule(const char *modName) { if (kldload(modName) != -1) return 1; else return 0; } > >> >> Those interested in killing old drm2 on amd64 can add the >> requisite .if ... .endif to remove obsolscent *.ko. >> >>> IMHO it is issues like this (having out of date code that supports some >>> edge cases) which makes it harder for developers to dog-food the actual >>> OS they are developing on. >> >> You're talking to 1 of the 3 contributors that has tried over >> the last 2 decades to improve libm (both its quality and >> conformance to standards). The development and testing is >> done on my old i386 laptop (which happily uses drm2), my >> amd64 systems, and at one time sparc64 (flame.freebsd.org). >> So, yeah, i386 and sparc64 allowed me to dog-food my code. >> >> BTW, there are uncountable many integers. How about avoiding >> the conflict by using, say, '3' as in drm3. >> >> -- >> Steve >> >