From nobody Wed Dec 21 23:13:06 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ncq423MXNz1HQkv; Wed, 21 Dec 2022 23:13:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ncq422dLBz3mWZ; Wed, 21 Dec 2022 23:13:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671664386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pA3c41eb6XCpV7FyjWjVSNkHfAQGHk/xFW39+y6YbKM=; b=Z1u1Kxh0PSMP3vIrVlBtsaSRl/OuZ75VJCKO9eYNzKD8nr50Y1tUGCdasrFQiixD2x93u1 JKjzkLj8zYIJU+a0buF7V/jkkhTNKk2MEDdUT/O0012X8nqbSKswWiiO77wzY6fiPwQhMD wrw8ysSKBjZTV72St3y66ynjtbZ5plDhAhkyRzncy3ZBUeBM9x+InEqltG6Q9O3En6+aHX FQmmInnnIcN1ObSheW5vzKAyDl5pM3OHJ+IllTTJGIx8wAwREo7/wjE+ZcKKqQnrcGQ4Ka 82uuQjPo+Y+Smigan+XPUzAEZ5L3jXYpD9b1LQz/tDuFp5Qh7XuU1eWl6Y7v+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671664386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pA3c41eb6XCpV7FyjWjVSNkHfAQGHk/xFW39+y6YbKM=; b=kvxsF3GS9cNtft82b0H4DtCcyS96avWGs+aKComJh6A8kzq6BXCSH81nQOS+8L3Hxgj6Sg +CzWlbKRf/sm13L+jfIpzMo+cGcOsZYXGpQKN3udNS1ZU7E0sbvnqR4sLilYQdHnge42I6 go5k7NE6q1nUcDEjpFC1CZb+dX3lcZkIVCwJmNP1P5AbE0cJATu2ARBRLBEVLgCSfHuBw+ vkRJeKG8gtuslcZnAlYCwSEOKgupGVJaYlvXsrCseLobq1TZwUe47tMQks6rzppwhj7oWf V+GzGzJumhdaPqQX5wAWBTNVb1S1Hjzq5wzVnzlusMkSXNbLyoNK4kZ5x7PdWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1671664386; a=rsa-sha256; cv=none; b=yd/hcfP7h/v/1RucTcT5i3iVnwtitz71gCLDIJlJUeVW++L2J0JDvrpCI1Kp1QAV2or3/R MDN/V4P8rMuih6CCM6CSv85Jc2Kp7fQ3HEgw+HH5r1Fe1Ms4FXhRVVBE+p2FSCWd517JZG /PDLbI+oXdaw6FnaBLL+HhLnSZO4HD0uxQ8K0cMNmAcdgbdiIEqTAPfy5G7LwmayT2IrGf NdmX3f4XGeh6JhJxT3wpwnHU9zaPLQnPE86mR4/p6h7ns8pIg9sv8UHWWBbA7utc2tju1N BGqr9YLK+Dfo2WZI3LgppSJIPOFvIcf1OWytgmhPKVu00dINexAUrMwr8uVgcQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ncq421g71zXjc; Wed, 21 Dec 2022 23:13:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2BLND6OA070701; Wed, 21 Dec 2022 23:13:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2BLND65k070700; Wed, 21 Dec 2022 23:13:06 GMT (envelope-from git) Date: Wed, 21 Dec 2022 23:13:06 GMT Message-Id: <202212212313.2BLND65k070700@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 3fe0cb6695e0 - main - rpc.tlsclntd: Check for a tls syscall failure. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3fe0cb6695e062b5474ae957bf1856e85ba890bd Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=3fe0cb6695e062b5474ae957bf1856e85ba890bd commit 3fe0cb6695e062b5474ae957bf1856e85ba890bd Author: Rick Macklem AuthorDate: 2022-12-21 23:12:06 +0000 Commit: Rick Macklem CommitDate: 2022-12-21 23:12:06 +0000 rpc.tlsclntd: Check for a tls syscall failure. Although the tls syscall to set up the upcall should not normally fail, the daemon should check for such a failure. This patch adds a check for that failure. MFC after: 1 week --- usr.sbin/rpc.tlsclntd/rpc.tlsclntd.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/usr.sbin/rpc.tlsclntd/rpc.tlsclntd.c b/usr.sbin/rpc.tlsclntd/rpc.tlsclntd.c index 841c0b4e3114..caa3b5266e48 100644 --- a/usr.sbin/rpc.tlsclntd/rpc.tlsclntd.c +++ b/usr.sbin/rpc.tlsclntd/rpc.tlsclntd.c @@ -285,7 +285,14 @@ main(int argc, char **argv) err(1, "Can't register service for local rpctlscd socket"); } - rpctls_syscall(RPCTLS_SYSC_CLSETPATH, _PATH_RPCTLSCDSOCK); + if (rpctls_syscall(RPCTLS_SYSC_CLSETPATH, _PATH_RPCTLSCDSOCK) < 0) { + if (rpctls_debug_level == 0) { + syslog(LOG_ERR, + "Can't set upcall socket path errno=%d", errno); + exit(1); + } + err(1, "Can't set upcall socket path"); + } rpctls_svc_run();