From nobody Sun Mar 16 15:06:30 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZG1dz20C8z5qcHj for ; Sun, 16 Mar 2025 15:06:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZG1dz1SGkz3XvJ for ; Sun, 16 Mar 2025 15:06:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742137591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X8bEInI3TQwpNE/NiUwSSGUpvKnuUB/ELkvm7PU2y/Q=; b=v9T1Jt8jhashadWgENb9PgqydfXqtNhrTjSf+ll2acmZJRtM3gdU5tpQBmt/qo6WI3sUiD g/OKotOLXnNuvoKVLrJQgetMXdZtTIXyZenjfW3nvLY7seTyvbhe0MqBbaxwA8Rc3lAvlO 2wwmLo6pzCv+xjBN9LhbUllojvgFdLayCZhZ2waq1MW/tjhcvJ8LMEuLPM/LLB+7NOpXbr 63SRyKzyZg844Ispjcaw6pFEp1EeyE4wa42rfJEgz5bmwSK3onYFy1Qs7UEHjXMI8P+gN0 02lJKBSqa1M9WgmxlabE8fm6CtRTZx3wKs5U+rFIum1eV0t1VT1jZ+AlMgSwtg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1742137591; a=rsa-sha256; cv=none; b=E6mowS3gN+hT4Vp+zpH2nMymGPU6JDhWNns648VDlcWvoj3DsFWzy8opJ84kZyTiZ96R35 1J11RIXg90eMr0UE25AweQuporKmOqJsif74zYh2GGISscNUanPaiwyadVBvKfdabqQnx1 94y4wr2QbHGoS/dospdqks4UQsUtw44aeJiVenlhu8keiAQMTUYIIrD5kw2wglq3VBQLC6 sPDCVqTZ47TQ/iorrg6NTO9Jvv+vLbHI37QOBrMxM/JRA58lKkcqZGWwwQ8ESNTeAvXxHu H/cN10LKc0Lj7S+Jk4mFN6lCjJsWIjlCZAvk0ON/g9OIzCeucof0Wff3fPshMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742137591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X8bEInI3TQwpNE/NiUwSSGUpvKnuUB/ELkvm7PU2y/Q=; b=kLn65+MzkLwVK9X4PCHkjrhmDa1Ns8ct8IGuy+8RK0l4BXKOEzOyzbPiJ1CCRQGjoAXN48 XuOHPkBeJjTgM1OQdsLHh4wK+d28QmVPTABBmxQQdlndsDgQjcei0rxTr2V9UC2mw+OB0y I3seIlKQHVXs/CIv8zUTMqiuhSeGYGEKsDFKs06QksP19ivJexWnVPLvf6qiyt7apgb4G3 Q96RDuKTuQOIPpwbKkct7vDSJxk6+tE4TzWtIwmjMVBnAyAAZ7Ix33mV+Z457aZZCOLOGT phJfdQkj/OmHd4FohA2lljCEhliR5PSle66R2tSjCJshYmKptZDaZ43VjQmMEQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZG1dz0hBhz15QB for ; Sun, 16 Mar 2025 15:06:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 52GF6Uwk080493 for ; Sun, 16 Mar 2025 15:06:30 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 52GF6U9x080492 for net@FreeBSD.org; Sun, 16 Mar 2025 15:06:30 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 137145] [mbuf] Reference count computing isn't correct when more than one threads call function m_copypacket Date: Sun, 16 Mar 2025 15:06:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D137145 --- Comment #12 from Andriy Gapon --- (In reply to Konstantin Belousov from comment #11) Perhaps Tx that is keeping its reference. I don't know what kind of code people can write to manipulate mbuf, this is just a theoretical example. Larger point is why have the special case, does it provide a lot of win for performance? I know that atomic operations are expensive. A branch is not free, however, too. Always doing the atomic update is straightforward and safe(r). --=20 You are receiving this mail because: You are the assignee for the bug.=