From owner-cvs-all@FreeBSD.ORG Wed Aug 16 21:44:33 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB64316A4DD; Wed, 16 Aug 2006 21:44:33 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.t-hosting.hu (server.t-hosting.hu [217.20.133.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id 30EC143D7C; Wed, 16 Aug 2006 21:44:22 +0000 (GMT) (envelope-from gabor@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by server.t-hosting.hu (Postfix) with ESMTP id 2D7AF99B4BE; Wed, 16 Aug 2006 23:44:20 +0200 (CEST) X-Virus-Scanned: amavisd-new at t-hosting.hu Received: from server.t-hosting.hu ([127.0.0.1]) by localhost (server.t-hosting.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id bLNqs-Xz0PG5; Wed, 16 Aug 2006 23:44:18 +0200 (CEST) Received: from [192.168.2.186] (catv-50635cb6.catv.broadband.hu [80.99.92.182]) by server.t-hosting.hu (Postfix) with ESMTP id 6126E99B4B6; Wed, 16 Aug 2006 23:44:18 +0200 (CEST) Message-ID: <44E391AD.3010402@FreeBSD.org> Date: Wed, 16 Aug 2006 23:44:13 +0200 From: =?UTF-8?B?R8OhYm9yIEvDtnZlc2TDoW4=?= User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Maxim Sobolev References: <200608041234.k74CYoc1076722@repoman.freebsd.org> <44E389AA.3000003@FreeBSD.org> <44E38E2F.4000005@FreeBSD.org> In-Reply-To: <44E38E2F.4000005@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-all@FreeBSD.org, cvs-ports@FreeBSD.org, Erwin Lansing , FreeBSD Developers , ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.emacs.mk bsd.gnome.mk bsd.mail.mk bsd.openssl.mk bsd.port.mk bsd.port.subdir.mk bsd.python.mk bsd.ruby.mk bsd.scons.mk ports/Tools/scripts security-check.awk ports/databases/p5-DBD-Oracle Makefile ports/databases/p5-sqlrelay ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2006 21:44:33 -0000 Maxim Sobolev wrote: > Maxim Sobolev wrote: >> I think the solution proposed in PR/100555 is overengineered. Why not >> to build temporary binary package as usually and then use chroot(8) >> (or -C flag for pkg_install) to install it into DESTDIR environment? >> This would be *much* simpler approach and it won't require modifying >> anything but bsd.port.mk. Putting additional load on port maintainers >> on keeping their ports DESTDIR-clean is too much for such a niche >> feature. > > Just to make clean: what I am proposing is the following course of > actions when DESTDIR is defined: > > 1. Build port as usually. Install it as usually. > > 2. After usual installation is complete build temporary binary package > out of it and install it into DESTDIR environment. > > Automating it would require some amount of work, granted, but it would > be one time task, not constant burden on port maintainers. > > -Maxim I don't think it would be good, since: 1, The package building requires that the package be installed first, and we don't want to make the host environment dirty in such way. 2, We can have a host environment with another set of dependencies. E.g foo depends on php, but we have php5 in host environment, but php4 in DESTDIR. The package will be linked against php5 libs then and can't work under DESTDIR. Btw, Kris has an another good solution: http://lists.freebsd.org/pipermail/freebsd-ports/2006-August/034835.html -- Cheers, Gabor