From owner-p4-projects@FreeBSD.ORG Sat Apr 28 22:11:03 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 7437416A40B; Sat, 28 Apr 2007 22:11:03 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4602416A400; Sat, 28 Apr 2007 22:11:03 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mxout2.cac.washington.edu (mxout2.cac.washington.edu [140.142.33.4]) by mx1.freebsd.org (Postfix) with ESMTP id 21FA513C45E; Sat, 28 Apr 2007 22:11:03 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from smtp.washington.edu (smtp.washington.edu [140.142.33.7] (may be forged)) by mxout2.cac.washington.edu (8.13.7+UW06.06/8.13.7+UW07.03) with ESMTP id l3SMB2sF021260 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 28 Apr 2007 15:11:02 -0700 X-Auth-Received: from [192.168.10.45] (c-67-187-164-17.hsd1.ca.comcast.net [67.187.164.17]) (authenticated authid=youshi10) by smtp.washington.edu (8.13.7+UW06.06/8.13.7+UW07.03) with ESMTP id l3SMB12U013488 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 28 Apr 2007 15:11:02 -0700 Message-ID: <4633C67D.8010703@gmail.com> Date: Sat, 28 Apr 2007 15:11:09 -0700 From: Garrett Cooper User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: attilio@FreeBSD.org References: <200704271246.l3RCkoMJ051651@repoman.freebsd.org> <46326366.50907@FreeBSD.org> In-Reply-To: <46326366.50907@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Version: 5.3.1.294258, Antispam-Engine: 2.5.1.298604, Antispam-Data: 2007.4.28.144933 X-Uwash-Spam: Gauge=IIIIIII, Probability=7%, Report='FORGED_FROM_GMAIL 0.1, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FROM_GMAIL 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0, __USER_AGENT 0' Cc: Perforce Change Reviews Subject: Re: PERFORCE change 118874 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Apr 2007 22:11:03 -0000 Attilio Rao wrote: > Alexey Tarasov wrote: >> http://perforce.freebsd.org/chv.cgi?CH=118874 >> >> Change 118874 by taleks@taleks_th on 2007/04/27 12:46:48 >> >> added code from pxe.c. Now need to find way to install NIC irq >> handler. >> >> Affected files ... >> >> .. //depot/projects/soc2007/taleks-pxe_http/pxe_core.c#3 edit >> .. //depot/projects/soc2007/taleks-pxe_http/pxe_core.h#3 edit >> >> Differences ... >> >> ==== //depot/projects/soc2007/taleks-pxe_http/pxe_core.c#3 (text+ko) ==== >> >> @@ -1,8 +1,38 @@ >> +#include >> +#include >> #include "pxe_core.h" >> #include "pxe_mem.h" >> #include "pxe_ip.h" >> #include "pxe_mutex.h" >> >> +#include "btxv86.h" >> +#include "pxe.h" >> + >> + >> +/* PXE API calls here will be made in same way as in pxeboot. >> + the only difference - installation of isr, that was not needed in >> pxe.c. >> + main problem is that, v86 monitors reflects interrupts, >> + we need to change IDT, for correct irq and call pxe_core_isr() >> from it. >> +*/ >> + >> +/* NOTE: to think about using of this buffers */ >> +#define PXE_BUFFER_SIZE 0x2000 >> +#define PXE_TFTP_BUFFER_SIZE 512 >> +static char scratch_buffer[PXE_BUFFER_SIZE]; >> +static char data_buffer[PXE_BUFFER_SIZE]; >> +static pxenv_t *pxenv_p = NULL; /* PXENV+ */ >> +static pxe_t *pxe_p = NULL; /* !PXE */ >> +static BOOTPLAYER bootplayer; /* PXE Cached information. */ >> + >> +/* defined in pxetramp.s */ >> +extern u_int16_t __bangpxeseg; >> +extern u_int16_t __bangpxeoff; >> +extern void __bangpxeentry(void); >> +extern u_int16_t __pxenvseg; >> +extern u_int16_t __pxenvoff; >> +extern void __pxenventry(void); >> + >> +/**/ > > Could you, please, use here uint16_t instead than u_int16_t as style(9) > suggests? > > Attilio Just checking, but is this the same for other data types, i.e. u_int_32_t => uint32_t? I'm asking because I'm working with the BDB code, and I think it's using C99 or older format data elements / types. Thanks, -Garrett