From owner-svn-src-all@freebsd.org Thu Feb 11 19:06:22 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41C14AA6E33 for ; Thu, 11 Feb 2016 19:06:22 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm3-vm0.bullet.mail.bf1.yahoo.com (nm3-vm0.bullet.mail.bf1.yahoo.com [98.139.212.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E1FD51A85 for ; Thu, 11 Feb 2016 19:06:21 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1455217574; bh=U5wZNBCcnHJsrOxiQx0nLOFEoYND7bdxpbCKFB1AzFE=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=lZzA2gSTJYZda4aFn+1k93HF2XOpM7qp6jXEMGH8VtLnEpjZGs2G62sTD/Tw8ItYj/BdZ22Jyii4T2odH4VSOEIfH0+1655uOnxGGtnUdkedCZnJi1qzrSm3Q4jAdlShINwil8qld4VK6iPL30H2XuuFmmS6r0yrOkvoVGT6H58SExTeVPa5LLOz8KmY+kN5E4t8xfv35Ao1TppXQOnuFsg/E9e2Y8a8wBeokUY/kgzmRQP0i3QJxIBO8K+Q9C3aMoywUpQXJBfcSPWunPsmeAyMndMzGp4SiV+3xuOU9bckIh7Kh0RTjzIrQ83LARs58cIuzpZP4T2vwVM8+L0KVQ== Received: from [66.196.81.170] by nm3.bullet.mail.bf1.yahoo.com with NNFMP; 11 Feb 2016 19:06:14 -0000 Received: from [98.139.211.200] by tm16.bullet.mail.bf1.yahoo.com with NNFMP; 11 Feb 2016 19:06:14 -0000 Received: from [127.0.0.1] by smtp209.mail.bf1.yahoo.com with NNFMP; 11 Feb 2016 19:06:10 -0000 X-Yahoo-Newman-Id: 914600.44526.bm@smtp209.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: OTUcLf4VM1kGLT_9rhskKKhYf6MPrbaritSepFlw6sfx_tW 9Uckwxpd7wboT.tkARKB9VxqlwgQE55WBokChZb1xNkygeEisC0jRmmV74e. L3F4NjuV2j7MBS.os0.pxDq7nBSkzdoLFWVXXacpgxE3u3z5cUzVWlff01TQ AFVHAeFcyvez2s1cpuUnW2Du7FlQxx4D0O9k8K.h2nNUnDK5dzlkUeJVxZwk Zu9Np8WQ3HbFRD36nz4VLsQFJDDvIY16EZp5Rlux6JSKe4wPu0LfXSwLyc9C KtphJAy5_DJW9vfSvcZk_kIf_34FU2QZ5TxXS8WveUU7aC2GUIWeihhsluYb 2WE8zQbu2oOqDIswi6bCqLBm9K5mlbmeElgdSkBx8pD3wEkulRuMpbB8jz4Q ou4wnYDRg1NL2uMTUYr2uA.q3zsw6axMni_GWZIep0ZsCssDEI0Akm2juSO3 kcia2ir6K0xF9TEi2yLc0qmySkX8d4XsCekAhRnP5Vi9Lki5IjBYHrHF8jBi LUI68jhXg0_zRWTZ_ElmsaCKpec44j0n3 X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r294327 - in head/sys: dev/cxgb dev/cxgbe dev/e1000 dev/hyperv/netvsc dev/ixgbe dev/mxge netinet sys To: Warner Losh References: <201601191533.u0JFXSxf037804@repo.freebsd.org> <56BAE4BC.9000105@selasky.org> <56BB5280.5060609@FreeBSD.org> Cc: Hans Petter Selasky , Ryan Stone , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Pedro Giffuni Message-ID: <56BCDBB1.9000202@FreeBSD.org> Date: Thu, 11 Feb 2016 14:06:25 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2016 19:06:22 -0000 On 02/11/16 11:47, Warner Losh wrote: > > > On Wed, Feb 10, 2016 at 8:08 AM, Pedro Giffuni > > FWIW, our libc qsort() has an additional enhancement: > > http://svnweb.freebsd.org/base?view=revision&revision=279663 > > In my measurements qsort(3) was now always faster than mergesort(3). > > > If it is faster, is there any good reason to maintain both qsort and > mergesort in the kernel then? > I don't know, that happened ages ago, way before I was around ;). The late enhancement is only in the libc qsort and the code is likely to be different in other ways (is it recursive? .. haven't looked). I think I saw some comments somewhere about degenerate cases that affect our version of qsort, but the performance is known to be very good[1]. Pedro. [1] http://calmerthanyouare.org/2013/05/31/qsort-shootout.html