From owner-svn-src-head@freebsd.org Sat Apr 15 03:13:55 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89926D3EEF5; Sat, 15 Apr 2017 03:13:55 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 54ABEE36; Sat, 15 Apr 2017 03:13:55 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x244.google.com with SMTP id i5so17186069pfc.3; Fri, 14 Apr 2017 20:13:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=N1qYd7azVucW/WZoUC0Jix+IlO+4w9+U7IHv4bXb51o=; b=h9Oj303ooOeT7kLluXXoet7KTajwTbnB4wyMwClQMmLVcS4wncpA1CB+11IUJto0rG ZCyrWPwOMqEVIWd879a4EGKWuWWQHNa8LFaoDH6pktKBkw/P9rOxH1XK5gEE8UD2aDvY T4gVY5KnWL8va+zvnc7AsoAdwXZlyVTnWh1Lbi3i/Bd2Sl4xt2eLF+oGMeLMnPACRFE8 uHWta8pAQSogEaRJG/EcEYKORZ0jhpRrYkYOfU+KeGl1ryTfzzE5MYeoJEa9YTqN1bJs pktFUYJiiKA7Vb0KtohBvIKPxNaIqBQ0n6roJE1UNFpAi8c8I+hkuCN93Na69PRmPKPo riwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=N1qYd7azVucW/WZoUC0Jix+IlO+4w9+U7IHv4bXb51o=; b=XOxUALkZC6+VacKfFPoMBZgvucEbuangk3H5ronVMEVYChyUl+DfxiUIbZsXDFZwlM tSm9q9fBtrzT+RjKqnD+Uc15rYa89Szzlik0Q/FRErwH4+v6ZvdV5jjaksqhO/bo9egD pJp7nFCQYM+0sleLBMsull/OhQFcZe6ayWh95BKtKJXZMHurL0M/+TSnnXlkNWXmIAyQ MA6nIqQ8OWTATto/XQvlqDz16CboRRN4RpZjRWQz34MUI9WovpqbwhyQdpojySvCmWf4 LHBl083GWszm4UB0TYY68+VsUDoPeLufPzD5enoAMB4S5NU5PSQIU9i9hsRO/oXro6ox MKUQ== X-Gm-Message-State: AN3rC/6/4GN2CL4Q4mwOvXKTfbf+idrjuvmzw8CHIVsglW8Qy3gLcyS9 +Pj4IMW87eP/jUBaeVk= X-Received: by 10.98.210.2 with SMTP id c2mr746191pfg.83.1492226034957; Fri, 14 Apr 2017 20:13:54 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id c64sm5458569pfa.110.2017.04.14.20.13.53 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Apr 2017 20:13:53 -0700 (PDT) Subject: Re: svn commit: r316874 - head/sys/kern Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_79513F97-9C0D-417F-A76A-8914AC4F4E2A"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <2109294.KVn8xeR1jZ@overcee.wemm.org> Date: Fri, 14 Apr 2017 20:13:52 -0700 Cc: svn-src-all@freebsd.org, src-committers , Hiroki Sato , Hiren Panchasara , svn-src-head@freebsd.org, Maxim Sobolev Message-Id: References: <201704141723.v3EHNS3B043902@repo.freebsd.org> <13691757.t3s7Qik7v1@overcee.wemm.org> <2109294.KVn8xeR1jZ@overcee.wemm.org> To: Peter Wemm X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Apr 2017 03:13:55 -0000 --Apple-Mail=_79513F97-9C0D-417F-A76A-8914AC4F4E2A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 14, 2017, at 20:12, Peter Wemm wrote: >=20 > On Friday, April 14, 2017 07:36:55 PM Peter Wemm wrote: >> On Friday, April 14, 2017 02:14:16 PM Ngie Cooper wrote: >>>> On Apr 14, 2017, at 14:10, Maxim Sobolev = wrote: >>>>=20 >>>> Peter, Ngie, >>>>=20 >>>> Looks like out of that refactoring came a logical bug that is = present in >>>> the head, which causes syslod to first to shutdown the socket for >>>> reading >>>> and then try to select/recv on it (which is somewhat stupid). And = that >>>> issue has been masked by shutdown() on datagram socket becoming >>>> effectively a NOP in 11 & head 20 months ago. It only affects head >>>> though, 11-stable still has the old code which does not include = that >>>> half-closed socket into the select list. Attached patch is expected = to >>>> fix head, Peter, it would be nice if you can give it a try = (restoring >>>> latest changes into uipc_sockets.c) and let me know if it helps. >>>>=20 >>>> Thanks! >>>=20 >>> CCing hrs@ for input as he did the refactoring. >>> Thanks! >>> -Ngie >>>=20 >>> PS LGTM with the change. Will wait for feedback from wemm@. >>=20 >> This is definitely not working. I get ENOSPC and listen queue = overflows on >> /var/run/logpriv now. >>=20 >> Grabbing an old 10.3 /usr/sbin/syslogd and placing it on the top of = the 12.x >> one worked fine, aside from the include statements. >=20 > This can't be right: > if (SecureMode || res->ai_family =3D=3D AF_LOCAL) { > /* Forbid communication in secure mode. */ > if (shutdown(s, SHUT_RD) < 0 && > errno !=3D ENOTCONN) { > logerror("shutdown"); > if (!Debug) > die(0); > } > dprintf("listening on socket\n"); > sl_recv =3D NULL; > } >=20 > This appears to disable unix domain sockets like /var/run/log and > /var/run/logpriv. ACK. This looks like a fun bug. -Ngie --Apple-Mail=_79513F97-9C0D-417F-A76A-8914AC4F4E2A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJY8Y/wAAoJEPWDqSZpMIYVld4P+wSZvWY/Mi1eEcmz7h3u4B4D PktRfN2fdnsVnFjKBLWOz5ys3IB5xWWDmopZqelK+a5q7ze+hLevmBWnJE1i6R87 uXS/IRiMfq/0v2o1CeAkFVjNuFgVhyn6w2z+76HFWV4YTOYrOYk9Ol/EnrIUsFUA WmoH31qx87LMDJW5nsZGsNgW2UjElGPC30I95pf0b0CLTz47uDwIuN+Jb55E4d9Q pPdFhEz2iVm6l86Cpd0DOX8wyQxoXtHb5LzPfHwZCOOzo3ehwCBM17A/zOMTQ7ZS TlpbBWHkD9BNq+3U/Eu51Bq+mBf4yTnn5fqFGfhtQvTLiV8gLDiyQ2KucNEMoVDx VQy0AI1tyZVfnme4o/h77XYbwbDD0cZGdz3xKE+cSqZ9lcNNxRhtZD6/SwGas8cJ l3CpPT2YC6jmHjAufrtc/MkYEjy7IMs5EQV2pER7xgP2Bq5HBGfgCWJ6VbgNFYIB 21a8JRoyzZLdMC+OsNuuk6LnB6dGV0x8VofefV9yT+2o0ZFGQ9p4WtldfTPiHkTi kIxA6w/lFyMgyOUOE+iWDdljMNXFG5W1qzxM8CCckVPCMO6jX1+5P53qbCRyMGZ8 DXDRz0JqQvAMWEXPDIiRceB5CMOxk8XK8XppMIuDJdNY+aUNVTWvPd8j2m8Km4/g CbiNw5iABeF6fmZbWThC =zLg3 -----END PGP SIGNATURE----- --Apple-Mail=_79513F97-9C0D-417F-A76A-8914AC4F4E2A--